| July 01, 2014 |
|---|
| 02:04 |
[Wireshark-commits] master 9a676ac: Fix access to uninitialised values |
Wireshark code review |
|
| 02:05 |
[Wireshark-commits] master c12f269: Fix access to uninitialised value |
Wireshark code review |
|
| 02:05 |
[Wireshark-commits] master 4e9e043: Init session id to avoid warning using GCC 4.9 |
Wireshark code review |
|
| 02:24 |
[Wireshark-commits] master 94e6bbe: Put each option on a line of its own. |
Wireshark code review |
|
| 03:23 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 04:15 |
[Wireshark-commits] master 659d0ef: sip optimization: avoid calling tvb_get_guint8. |
Wireshark code review |
|
| 04:21 |
[Wireshark-commits] master a452d16: Optimize epan_new/init_dissection |
Wireshark code review |
|
| 06:22 |
[Wireshark-commits] master eb23994: Generate version.h before adding subdirs (especially wsutil). Otherwise build could fail in wsutil because of missing version.h |
Wireshark code review |
|
| 09:24 |
[Wireshark-commits] master 5245832: GTK: Unlimited, dynamically allocated IO Graph |
Wireshark code review |
|
| 09:24 |
[Wireshark-commits] master f90bf8a: Increase space allocated for IO Graph slower after 1 million items |
Wireshark code review |
|
| 09:37 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 09:42 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 09:46 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 09:51 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 10:03 |
[Wireshark-commits] master deeb1de: Squelch some warnings. |
Wireshark code review |
|
| 10:06 |
[Wireshark-commits] master 9485392: Add a comment that appears in other programs. |
Wireshark code review |
|
| 10:11 |
[Wireshark-commits] master 0cf54e7: Drop privileges even earlier. |
Wireshark code review |
|
| 10:33 |
[Wireshark-commits] master 147db82: Log2() and exp2() are missing on Windows |
Wireshark code review |
|
| 12:44 |
[Wireshark-commits] master bd79dae: Remove debugging info from protocol tree for frame |
Wireshark code review |
|
| 14:24 |
[Wireshark-commits] master b5e266f: Keep VS Code Analysis happy |
Wireshark code review |
|
| 17:54 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 18:00 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 19:16 |
[Wireshark-commits] master e1e7dd0: Fix the QT build on Qt 5.3 or later to use the windeployqt tool to copy the rquired Qt files into the runtime directory |
Wireshark code review |
|
| 19:18 |
[Wireshark-commits] master 2211813: Add logic to config.nmake to find 64-bit cygwin, and a note warning about forward slashes in the QT5_BASE_PATH if the recommended qmake command is used; both of these issues will cause annoyingly non- obvious errors. |
Wireshark code review |
|
| 19:21 |
[Wireshark-commits] master 27d3201: Pick up stuff from GLib to hide symbols with Sun C. |
Wireshark code review |
|
| 19:27 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 19:27 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 19:27 |
[Wireshark-commits] master b378f72: Fix comments to reflect reality. |
Wireshark code review |
|
| 19:27 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 19:47 |
[Wireshark-commits] master aa0f809: Don't check for -Wl, {option} support. |
Wireshark code review |
|
| 20:19 |
[Wireshark-commits] master e696d0f: Fix the checks for the Cygwin path. |
Wireshark code review |
|
| 20:37 |
[Wireshark-commits] master 852d5da: Remove executable bit, from not executable files. |
Wireshark code review |
|
| 20:39 |
[Wireshark-commits] master a73199e: Use G_GNUC_PRINTF() for simple_message_box(). |
Wireshark code review |
|
| 20:49 |
[Wireshark-commits] master 2a306f4: Fix for Bug 10240. Include padding length in calculation of correct attribute length |
Wireshark code review |
|
| 20:50 |
[Wireshark-commits] master-1.12 5d2747c: Fix for Bug 10240. Include padding length in calculation of correct attribute length |
Wireshark code review |
|
| 21:05 |
[Wireshark-commits] master-1.10 bf80c22: Fix for Bug 10240. Include padding length in calculation of correct attribute length |
Wireshark code review |
|
| 22:30 |
[Wireshark-commits] master 5f682f1: Fix buildroot. |
Wireshark code review |
|
| 22:30 |
[Wireshark-commits] master-1.12 44b8729: Fix buildroot. |
Wireshark code review |
|
| 22:31 |
[Wireshark-commits] master a4a624e: Get rid of rpath when we're building RPMs. |
Wireshark code review |
|
| 22:31 |
[Wireshark-commits] master-1.12 d570514: Get rid of rpath when we're building RPMs. |
Wireshark code review |
|
| 23:04 |
[Wireshark-commits] master 22ea889: For Sun C with linker scoping specifiers, define WS_DLL_PUBLIC_DEF. |
Wireshark code review |
|
| 23:48 |
[Wireshark-commits] master ab1e6f3: Bump (again) the amount of work we do for wmem's timing test |
Wireshark code review |
|
| July 02, 2014 |
|---|
| 00:20 |
[Wireshark-commits] master ae26b12: If -fvisibility=hidden isn't supported, try -xldscope=hidden. |
Wireshark code review |
|
| 00:35 |
[Wireshark-commits] master 4cdfc5c: AUTHORS-SHORT is build in ${CMAKE_BINARY_DIR}, not ${CMAKE_SOURCE_DIR}. |
Wireshark code review |
|
| 00:48 |
[Wireshark-commits] master 096aca6: Make some inconsistent configuration options errors. |
Wireshark code review |
|
| 01:02 |
[Wireshark-commits] master 98d8dec: See if this forces version.h to be built. |
Wireshark code review |
|
| 01:21 |
[Wireshark-commits] master f737381: Add a note to Doc/docbook-xml42 requirement in docbook/README.txt indicating that a later version may be required; e.g. my a2x (from cygwin64) generates a developer-guide.xml that needs docbook-xml45. |
Wireshark code review |
|
| 06:07 |
[Wireshark-commits] master af75289: Optimize sip dissector: avoid calling tvb_get_string_enc() |
Wireshark code review |
|
| 06:08 |
[Wireshark-commits] master 09839e3: Update WSDG win32/win64 quick start guide to include dependencies and instructions for building QtShark; note alternate cygwin package for 'patch' utility; update example setup script to add Qt bin directory to PATH, and extract out paths as variables. |
Wireshark code review |
|
| 06:32 |
[Wireshark-commits] master 956c440: RSVP checksum is not required if integrity object is present |
Wireshark code review |
|
| 13:53 |
[Wireshark-commits] master 65e3f5c: Allow overriding C/C++ flags from CMake command line |
Wireshark code review |
|
| 15:57 |
[Wireshark-commits] master 0041f36: Make the flag testing logic for linker flags work like the compiler flag testing. |
Wireshark code review |
|
| 17:29 |
[Wireshark-commits] master a3bac6d: kafka: fully dissect offset request/response messages |
Wireshark code review |
|
| 17:35 |
[Wireshark-commits] master 980893a: NDPS dissector is the poster child for proto_tree_add_subtree[_format]. |
Wireshark code review |
|
| 20:27 |
[Wireshark-commits] master 2c9d2be: Fail if any of the install-exec-hook commands fails. |
Wireshark code review |
|
| 20:56 |
[Wireshark-commits] master f3c5f14: Manage Interfaces |
Wireshark code review |
|
| 21:54 |
[Wireshark-commits] master-1.12 fcea3cb: Fail if any of the install-exec-hook commands fails. |
Wireshark code review |
|
| July 03, 2014 |
|---|
| 01:33 |
[Wireshark-commits] master 0e4e825: Add license information to the copyright information. |
Wireshark code review |
|
| 02:03 |
[Wireshark-commits] master 66c342e: Regularize the first line of version output. |
Wireshark code review |
|
| 02:22 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 02:29 |
[Wireshark-commits] master 6b3391c: Regularize the help output of programs. |
Wireshark code review |
|
| 02:33 |
[Wireshark-commits] master a4304de: Add long-option support. |
Wireshark code review |
|
| 04:51 |
[Wireshark-commits] master 8afe331: More getopt_long, to add --help and --version support. |
Wireshark code review |
|
| 05:45 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 07:28 |
[Wireshark-commits] master 5889d4b: More getopt_long(), for --help and --version. |
Wireshark code review |
|
| 07:30 |
[Wireshark-commits] master 2dbab6d: GTP: add dissection of Extended End User Address |
Wireshark code review |
|
| 07:32 |
[Wireshark-commits] master d70e56a: Revert to 3ms if we don't have the handshake |
Wireshark code review |
|
| 08:04 |
[Wireshark-commits] master-1.12 a81265a: Allow overriding C/C++ flags from CMake command line |
Wireshark code review |
|
| 08:17 |
[Wireshark-commits] master-1.12 58d93e1: GTP: add dissection of Extended End User Address |
Wireshark code review |
|
| 08:46 |
[Wireshark-commits] master b4ce352: Make --help and --version information a bit more uniform. |
Wireshark code review |
|
| 08:54 |
[Wireshark-commits] master 6264b8a: Use get_*_int() from wsutil, rather than defining our own. |
Wireshark code review |
|
| 08:56 |
[Wireshark-commits] master 35c4721: Get rid of an extra blank line. |
Wireshark code review |
|
| 08:58 |
[Wireshark-commits] master a1ec669: Clean up printf() argument list. |
Wireshark code review |
|
| 08:59 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 09:00 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 09:04 |
[Wireshark-commits] master f0ed0e6: Get rid of soft-deprecated API:s |
Wireshark code review |
|
| 09:04 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 09:09 |
[Wireshark-commits] master edc6736: Add --help and --version support. |
Wireshark code review |
|
| 09:14 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 09:16 |
[Wireshark-commits] master 1692c52: Include "capture-pcap-util.h" even if we don't have libpcap. |
Wireshark code review |
|
| 09:19 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 09:22 |
[Wireshark-commits] master 1a165b9: We have to include version_info.obj manually in the dependencies for text2pcap. |
Wireshark code review |
|
| 09:53 |
[Wireshark-commits] master 470994d: Needs wsutil/wsgetopt.h if the platform doesn't have getopt_long(). |
Wireshark code review |
|
| 12:22 |
[Wireshark-commits] master 1657423: Try to fix the build by adding version_info.obj to the link stage of text2pcap and in both lines for mergecap. Follow up of https://code.wireshark.org/review/gitweb?p=wireshark.git; a=commit; h=1a165b9be8a122ee1d5c0a60ca441d2c9198b3fd |
Wireshark code review |
|
| 12:23 |
[Wireshark-commits] master 6ed9540: Fix type-o left over from cut-and-paste |
Wireshark code review |
|
| 13:02 |
[Wireshark-commits] master 16f8ba1: catapult, irda: Fix ASAN crashes due to buffer underrun |
Wireshark code review |
|
| 13:40 |
[Wireshark-commits] master 87cf043: Fix bulding of reordercap |
Wireshark code review |
|
| 14:07 |
[Wireshark-commits] master-1.12 71cb629: catapult, irda: Fix ASAN crashes due to buffer underrun |
Wireshark code review |
|
| 15:10 |
[Wireshark-commits] master f3c62ed: Move the GLib version info string stuff to get_glib_version_info(). |
Wireshark code review |
|
| 15:22 |
[Wireshark-commits] master 66b02c7: Include <sys/capaibility.h> to get _LINUX_CAPABILITY_VERSION defined. |
Wireshark code review |
|
| 17:15 |
[Wireshark-commits] master-1.12 047c4c0: packet-vnc.c: Improve re-assembly. |
Wireshark code review |
|
| 17:16 |
[Wireshark-commits] master 06bd804: Make wsutil depend on gitversion. |
Wireshark code review |
|
| 19:19 |
[Wireshark-commits] master 7dd27db: stat_menu.h moved to libui. |
Wireshark code review |
|
| 20:30 |
[Wireshark-commits] master 1c29777: Rename and move ui/stat_menu.h to epan/stat_groups.h. |
Wireshark code review |
|
| 20:32 |
[Wireshark-commits] master c62a905: Sometimes Git can be a real pain. |
Wireshark code review |
|
| 21:09 |
[Wireshark-commits] master 60a6f85: Manually revert "Make COMPUTE_OFFSET and COMPUTE_OFFSET_AND_REMAINING macros." |
Wireshark code review |
|
| 21:51 |
[Wireshark-commits] master df6bdcc: packet-vnc.c: Improve dissection |
Wireshark code review |
|
| 22:26 |
[Wireshark-commits] master 3e325b1: packet-vnc.c: Restore tvb_get_string() --> tvb_get_string_enc() changes lost in gdf6bdcc |
Wireshark code review |
|
| 22:55 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 23:34 |
[Wireshark-commits] master 4e74546: packet-vnc.c: Fix a bug in displaying a set of FT_BOOLEAN bit fields (found by checkAPIs). |
Wireshark code review |
|
| July 04, 2014 |
|---|
| 02:18 |
[Wireshark-commits] master 212df87: (trivial) moved 'is request' comment in dissect_usb_common() |
Wireshark code review |
|
| 02:20 |
[Wireshark-commits] master bbb3e2f: Add Bus ID to USB Address Column |
Wireshark code review |
|
| 02:21 |
[Wireshark-commits] master 7464415: Fix infinite loop in RTCP dissector |
Wireshark code review |
|
| 02:22 |
[Wireshark-commits] master fb4ee24: Sort by name list of file fix also indent (use spaces) |
Wireshark code review |
|
| 02:23 |
[Wireshark-commits] master-1.12 106c8b3: adding abs() functions when creating the values to be graphed since the graph only handles positive values. Does not apply to FT_RELATIVE_TIME. |
Wireshark code review |
|
| 02:33 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 02:49 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 02:51 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 02:55 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 03:13 |
[Wireshark-commits] master c5643a3: Remove accidental trailing \ |
Wireshark code review |
|
| 07:25 |
[Wireshark-commits] master 9e6487f: Move utility routines for capturing into a libcaputils static library. |
Wireshark code review |
|
| 07:39 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 07:41 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 07:44 |
[Wireshark-commits] master 3fb1124: capture_ifinfo.h moved to caputils. |
Wireshark code review |
|
| 07:59 |
[Wireshark-commits] master 7e970c3: wmemify some nfs functions, fixing much leaked memory |
Wireshark code review |
|
| 08:01 |
[Wireshark-commits] master 17995db: Fix the no-libpcap build. |
Wireshark code review |
|
| 08:03 |
[Wireshark-commits] master-1.12 3245a9f: ssl: add SslSession structure |
Wireshark code review |
|
| 08:03 |
[Wireshark-commits] master-1.12 a028288: dtls: use SslSession |
Wireshark code review |
|
| 08:04 |
[Wireshark-commits] master-1.12 9c1607f: ssl: use SslSession |
Wireshark code review |
|
| 08:05 |
[Wireshark-commits] master-1.12 098aa9f: ssl-utils: dissect the certificate type TLS extension |
Wireshark code review |
|
| 08:06 |
[Wireshark-commits] master-1.12 dcc01c2: ssl: fix ClientKeyExchange, fix TLSv1.2 SKE for DH |
Wireshark code review |
|
| 08:06 |
[Wireshark-commits] master d3a7176: Reflect the rename of get_XXX_pcap_version() to get_XXX_caplibs_version(). |
Wireshark code review |
|
| 08:06 |
[Wireshark-commits] master-1.12 600a505: ssl-utils: add missing ett registration |
Wireshark code review |
|
| 08:09 |
[Wireshark-commits] master fc52dc6: rawshark needs libcaputils. |
Wireshark code review |
|
| 10:51 |
[Wireshark-commits] master-1.12 f3a0092: Fix Windows build broken by g106c8b3 |
Wireshark code review |
|
| 10:52 |
[Wireshark-commits] master-1.12 34303a2: TCP: backport out of order packet detection algorithm from master branch |
Wireshark code review |
|
| 12:07 |
[Wireshark-commits] master 34d09f7: Add missing / |
Wireshark code review |
|
| 14:00 |
[Wireshark-commits] master dd424c6: Handle the case where the previous PDU has left an extra CRLF in the stream.RFC 2626 In the interest of robustness, servers SHOULD ignore any empty line(s) received where a Request-Line is expected. In other words, if the server is reading the protocol stream at the beginning of a message and receives a CRLF first, it should ignore the CRLF. |
Wireshark code review |
|
| 14:07 |
[Wireshark-commits] master-1.12 f12aac6: Fix qtshark compilation with more explicit casts (follow-up of g106c8b3) |
Wireshark code review |
|
| 14:37 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 16:46 |
[Wireshark-commits] master 9351704: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| 16:59 |
[Wireshark-commits] master c7a6e6f: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| 17:23 |
[Wireshark-commits] master 09511c2: Build libcaputils PIE, so it can be linked with dumpcap when it's built PIE. |
Wireshark code review |
|
| 19:38 |
[Wireshark-commits] master e398c8e: ETSI CAT: upgrade dissector to Release 12 |
Wireshark code review |
|
| 21:53 |
[Wireshark-commits] master c92bf7e: Expand a variable from 16 to 32 bits (and make it signed). |
Wireshark code review |
|
| 21:53 |
[Wireshark-commits] master-1.12 e166d36: Expand a variable from 16 to 32 bits (and make it signed). |
Wireshark code review |
|
| July 05, 2014 |
|---|
| 07:11 |
[Wireshark-commits] master 3686713: Update libnghttp2 to latest master (add support for draft-13) |
Wireshark code review |
|
| 09:50 |
[Wireshark-commits] master-1.12 62a429a: proto_tree_add_uint() takes a value, not an encoding, as an argument. |
Wireshark code review |
|
| 18:47 |
[Wireshark-commits] master 599b880: Handle the UTC timestamps in NetMon 2.3 files. |
Wireshark code review |
|
| 18:47 |
[Wireshark-commits] master-1.12 df61fac: Handle the UTC timestamps in NetMon 2.3 files. |
Wireshark code review |
|
| 18:49 |
[Wireshark-commits] master c8bcdd5: Fix whitespace issues. |
Wireshark code review |
|
| 18:49 |
[Wireshark-commits] master-1.12 6319ff6: Fix whitespace issues. |
Wireshark code review |
|
| 19:24 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 19:32 |
[Wireshark-commits] master 3f77251: Fix an error caught by enum-conversion warnings. |
Wireshark code review |
|
| 19:33 |
[Wireshark-commits] master-1.12 9b81e6b: Fix an error caught by enum-conversion warnings. |
Wireshark code review |
|
| 20:36 |
[Wireshark-commits] master fc63343: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| 21:02 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 22:04 |
[Wireshark-commits] master 286c191: 9p: fix version detection, fix dissect_9P retval |
Wireshark code review |
|
| 22:09 |
[Wireshark-commits] master 42b537e: Reset state when cycling ring-buffer files in tshark. |
Wireshark code review |
|
| 22:22 |
[Wireshark-commits] master 318205e: Fix an error caught by enum-conversion warnings. |
Wireshark code review |
|
| 23:08 |
[Wireshark-commits] master 0335ae3: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| July 06, 2014 |
|---|
| 01:13 |
[Wireshark-commits] master 570d52a: Pull the record processing into netmon_process_record(). |
Wireshark code review |
|
| 01:14 |
[Wireshark-commits] master-1.12 e13d4d4: Pull the record processing into netmon_process_record(). |
Wireshark code review |
|
| 01:20 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 01:21 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 01:21 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 01:23 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 01:24 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 01:30 |
[Wireshark-commits] master c654add: Add consts to casts to suppress warnings. |
Wireshark code review |
|
| 01:33 |
[Wireshark-commits] master ab5d1cf: Squelch a warning. |
Wireshark code review |
|
| 01:33 |
[Wireshark-commits] master-1.12 e851c0a: Squelch a warning. |
Wireshark code review |
|
| 01:50 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 02:26 |
[Wireshark-commits] master 8481c43: Fix more errors revealed by enum-to-integer conversion warnings. |
Wireshark code review |
|
| 02:26 |
[Wireshark-commits] master-1.12 8da0b0d: Fix more errors revealed by enum-to-integer conversion warnings. |
Wireshark code review |
|
| 03:35 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 08:03 |
[Wireshark-commits] master 3490bc6: Change display filters to prefix with ipmi.trace |
Wireshark code review |
|
| 08:08 |
[Wireshark-commits] master afa8f21: make-dissectors-reg: optimize by factoring out the loops |
Wireshark code review |
|
| 11:15 |
[Wireshark-commits] master 2a740bd: Squash casting-away-constness warnings. |
Wireshark code review |
|
| 11:25 |
[Wireshark-commits] master db530d8: Squelch casting-away-constness warnings. |
Wireshark code review |
|
| 14:21 |
[Wireshark-commits] master 6318a29: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| 14:27 |
[Wireshark-commits] master 4afd70d: Use g_hash_table_new_full to free some values |
Wireshark code review |
|
| 15:16 |
[Wireshark-commits] master 03d6f1b: [Automatic manuf, services and enterprise-numbers update for 2014-07-06] |
Wireshark code review |
|
| 15:27 |
[Wireshark-commits] master-1.12 3563b09: [Automatic manuf, services and enterprise-numbers update for 2014-07-06] |
Wireshark code review |
|
| 15:38 |
[Wireshark-commits] master-1.10 50f6f36: [Automatic manuf, services and enterprise-numbers update for 2014-07-06] |
Wireshark code review |
|
| 15:43 |
[Wireshark-commits] master b54731d: ms-mms: fix retval for short pkts, fix reading flags |
Wireshark code review |
|
| 15:45 |
[Wireshark-commits] master 2eae8bb: mikey: do not request more data on proto violation |
Wireshark code review |
|
| 15:47 |
[Wireshark-commits] master d828b15: kismet: fix retval, add modelines |
Wireshark code review |
|
| 15:51 |
[Wireshark-commits] master 5886e45: iscsi: minor retval fix |
Wireshark code review |
|
| 16:53 |
[Wireshark-commits] master be4d42c: Widen openflow variables and check for underflows |
Wireshark code review |
|
| 18:26 |
[Wireshark-commits] master c71e88e: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| 18:28 |
[Wireshark-commits] master 84189de: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 18:30 |
[Wireshark-commits] master 841b1d6: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 18:30 |
[Wireshark-commits] master 550f611: RTCP: fix typo (double semicolon) |
Wireshark code review |
|
| 18:31 |
[Wireshark-commits] master 68daa66: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 18:32 |
[Wireshark-commits] master c35b82c: RTCP: Make checkhf happy |
Wireshark code review |
|
| 19:11 |
[Wireshark-commits] master 4e9802e: H264: Add support of packetization modes, SVC, MS-H264 |
Wireshark code review |
|
| 19:14 |
[Wireshark-commits] master 032c261: GTK: fix crash when closing Capture Options dialog box on Windows |
Wireshark code review |
|
| 19:23 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 19:23 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 19:44 |
[Wireshark-commits] master e649420: H264: mark a parameter as unused |
Wireshark code review |
|
| 19:59 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 21:03 |
[Wireshark-commits] master 5bfc21c: Clean up handling of missing functions. |
Wireshark code review |
|
| 22:05 |
[Wireshark-commits] master 49bc104: whois, finger: fix retval, convert from tvb_length |
Wireshark code review |
|
| 22:53 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 22:53 |
[Wireshark-commits] master ec6a22d: Workaround for ASAN failure in _ws_mempbrk_sse42 |
Wireshark code review |
|
| 23:00 |
[Wireshark-commits] master f2b4daf: Add printf-format annotations, fix garbage |
Wireshark code review |
|
| 23:49 |
[Wireshark-commits] master 79fcc6a: Squelch some compiler warnings. |
Wireshark code review |
|
| July 07, 2014 |
|---|
| 00:03 |
[Wireshark-commits] master 4d58904: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| 00:12 |
[Wireshark-commits] master 0a2f6fc: Squelch some compiler warnings. |
Wireshark code review |
|
| 01:47 |
[Wireshark-commits] master aa4066d: skinny: fix retval, convert from tvb_length |
Wireshark code review |
|
| 04:29 |
[Wireshark-commits] master eea2e15: G_GNUC_FORMAT encapsulates __attribute((format_arg(...))). |
Wireshark code review |
|
| 04:32 |
[Wireshark-commits] master 9dfb3e7: Wrong macro. |
Wireshark code review |
|
| 04:34 |
[Wireshark-commits] master e286acd: Squelch compiler warning. |
Wireshark code review |
|
| 04:46 |
[Wireshark-commits] master 5938782: Don't cast away constness if not necessary. |
Wireshark code review |
|
| 06:24 |
[Wireshark-commits] master 4cdd17a: Qt: Cache packet list column strings. |
Wireshark code review |
|
| 07:24 |
[Wireshark-commits] master 4ce4e3a: make-dissector-reg: minor tweaks |
Wireshark code review |
|
| 10:25 |
[Wireshark-commits] master 3c638d8: Fix Branch condition evaluates to a garbage value found by Clang Analyzer |
Wireshark code review |
|
| 10:42 |
[Wireshark-commits] master 7801a97: Trying to create and use an empty tvb now throws an exception. Just pass current tvb to mac-lte dissector. |
Wireshark code review |
|
| 14:34 |
[Wireshark-commits] master 4ac9895: See if yhis fixes "cast discards '__attribute__((const))' qualifier from pointer target type" |
Wireshark code review |
|
| 15:16 |
[Wireshark-commits] master 1ff6213: Try to fix cast discards '__attribute__((const))' qualifier from pointer target type |
Wireshark code review |
|
| 19:50 |
[Wireshark-commits] master-1.12 6217370: Add a cast to satisfy the buildbots. |
Wireshark code review |
|
| 19:50 |
[Wireshark-commits] master-1.12 337aebe: Add printf-format annotations, fix garbage |
Wireshark code review |
|
| 22:12 |
[Wireshark-commits] master 858558e: Update README.qt and add todo items. |
Wireshark code review |
|
| 22:29 |
[Wireshark-commits] master-1.12 bade563: Squelch some compiler warnings. |
Wireshark code review |
|
| 22:30 |
[Wireshark-commits] master-1.12 97d02ae: Squelch some compiler warnings. |
Wireshark code review |
|
| 22:31 |
[Wireshark-commits] master-1.12 4b8f8b3: G_GNUC_FORMAT encapsulates __attribute((format_arg(...))). |
Wireshark code review |
|
| 22:31 |
[Wireshark-commits] master-1.12 88aa372: Wrong macro. |
Wireshark code review |
|
| 22:45 |
[Wireshark-commits] master-1.12 e74a58b: Squelch compiler warning. |
Wireshark code review |
|
| July 08, 2014 |
|---|
| 00:49 |
[Wireshark-commits] master cdf6d62: tools/pre-commit: Complete all checks on all files before exiting with Ok/Fail status. |
Wireshark code review |
|
| 03:40 |
[Wireshark-commits] master 390e9bb: Fix Dereference of null pointer found by Clang analyzer |
Wireshark code review |
|
| 03:40 |
[Wireshark-commits] master e82e137: Fix Dereference of null pointer found by Clang analyzer |
Wireshark code review |
|
| 03:45 |
[Wireshark-commits] master 9b4f16a: gsmtap: do not abort if dissector is unavailable |
Wireshark code review |
|
| 03:46 |
[Wireshark-commits] master 8fbc0db: conversion: do not free conversation memory on updates |
Wireshark code review |
|
| 04:21 |
[Wireshark-commits] master 9d5bf53: udvm: free the buffer *before* throwing the exception |
Wireshark code review |
|
| 04:22 |
[Wireshark-commits] master-1.12 6cc7671: udvm: free the buffer *before* throwing the exception |
Wireshark code review |
|
| 06:15 |
[Wireshark-commits] master 46b3dda: iscsi: automatically detect data segment digest |
Wireshark code review |
|
| 06:18 |
[Wireshark-commits] master 36c3933: Dissect HTTP/2 draft-13 |
Wireshark code review |
|
| 06:23 |
[Wireshark-commits] master a6fc598: Enhance HTTP/2 HPACK header decompression handling |
Wireshark code review |
|
| 06:30 |
[Wireshark-commits] master 55ce1bc: Upgrade LPP dissector to v11.5.0 |
Wireshark code review |
|
| 10:36 |
[Wireshark-commits] master 033249e: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 10:38 |
[Wireshark-commits] master 4e478aa: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 10:39 |
[Wireshark-commits] master b0a7251: Fix Uninitialized argument value found by Clang Analyzer |
Wireshark code review |
|
| 13:14 |
[Wireshark-commits] master a7e616d: Fix the flex wrapper to ensure Cygwin /bin is on the path for Windows. This is needed for CMake, as it doesn't add Cygwin to the path for the generated solutions. |
Wireshark code review |
|
| 13:26 |
[Wireshark-commits] master fdc7e5a: better description of ifaces and all_ifaces |
Wireshark code review |
|
| 13:39 |
[Wireshark-commits] master 32ae573: don't print the interface description if it's null |
Wireshark code review |
|
| 15:17 |
[Wireshark-commits] master ac52c06: RRC: fix ASN.1 description by manually adding CR5591 |
Wireshark code review |
|
| 15:18 |
[Wireshark-commits] master 17872b5: Fix setting PT_IBQP type |
Wireshark code review |
|
| 15:22 |
[Wireshark-commits] master-1.12 97be684: RRC: fix ASN.1 description by manually adding CR5591 |
Wireshark code review |
|
| 20:00 |
[Wireshark-commits] master b66f614: pre-commit: Add 'unset GREP_OPTIONS' (similar to Gerrit commit-msg) |
Wireshark code review |
|
| 20:12 |
[Wireshark-commits] master-1.12 de09662: tools/pre-commit: Complete all checks on all files before exiting with Ok/Fail status. |
Wireshark code review |
|
| 20:13 |
[Wireshark-commits] master-1.12 8a47b3a: pre-commit: Add 'unset GREP_OPTIONS' (similar to Gerrit commit-msg) |
Wireshark code review |
|
| 22:06 |
[Wireshark-commits] master cfee201: LTE RRC: upgrade dissector to v11.8.0 |
Wireshark code review |
|
| July 09, 2014 |
|---|
| 00:25 |
[Wireshark-commits] master 6691293: convert to proto_tree_add_subtree[_format] |
Wireshark code review |
|
| 04:34 |
[Wireshark-commits] master 5f0fd97: Wireshark Qt: Fix recent (update the list of file when quit Wireshark) |
Wireshark code review |
|
| 05:31 |
[Wireshark-commits] master 4b5967f: Moved nghttp2 to epan Cleaned up nghttp2 build |
Wireshark code review |
|
| 12:34 |
[Wireshark-commits] master 72e15f2: Merge capture->interfaces and capture->options |
Wireshark code review |
|
| 13:37 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 18:03 |
[Wireshark-commits] master 4418986: HDMI: remove useless include |
Wireshark code review |
|
| 18:05 |
[Wireshark-commits] master 9f3c429: MAC LTE: interpret RAR TPC command |
Wireshark code review |
|
| 19:29 |
[Wireshark-commits] master 2cb5937: CMake : fix name of HTML Viewer to display also the exe path |
Wireshark code review |
|
| 19:29 |
[Wireshark-commits] master a93d2ea: CMake : Set html viewer exe path in HTML_VIEWER variable (and no set or unset..), autotools only add exe name |
Wireshark code review |
|
| 19:30 |
[Wireshark-commits] master 813aa93: Cmake : (Find XLST Proc) fix indent (use 4spaces) |
Wireshark code review |
|
| 21:02 |
[Wireshark-commits] master cdc1c16: Print wIndex in decimal and hex |
Wireshark code review |
|
| 21:39 |
[Wireshark-commits] master da3634a: Fix a "recent items" crash. |
Wireshark code review |
|
| 22:05 |
[Wireshark-commits] master bb9a251: Add back actionFileQuit. |
Wireshark code review |
|
| 22:37 |
[Wireshark-commits] master b2bf078: h264: Remove unneeded errata checks. |
Wireshark code review |
|
| 23:23 |
[Wireshark-commits] master c5a50df: See if we can get rid of the "lib" in front of "wsutil" on Windows. |
Wireshark code review |
|
| 23:29 |
[Wireshark-commits] master 28719a4: More needed to get rid of "lib" in "libwsutil" on Windows. |
Wireshark code review |
|
| 23:32 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 23:44 |
[Wireshark-commits] master 2fbedef: A few more changes to remove "lib" from "libwsutil" on Windows. |
Wireshark code review |
|
| July 10, 2014 |
|---|
| 00:08 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 00:37 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 00:58 |
[Wireshark-commits] master b1c9d0f: Revert "A few more changes to remove "lib" from "libwsutil" on Windows." |
Wireshark code review |
|
| 00:59 |
[Wireshark-commits] master ea721b8: Revert "More needed to get rid of "lib" in "libwsutil" on Windows." |
Wireshark code review |
|
| 00:59 |
[Wireshark-commits] master 9b182b7: Revert "See if we can get rid of the "lib" in front of "wsutil" on Windows." |
Wireshark code review |
|
| 01:06 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 01:51 |
[Wireshark-commits] master e6c87fe: convert to proto_tree_add_subtree[_format] for plugin dissectors |
Wireshark code review |
|
| 07:31 |
[Wireshark-commits] master e1bad3c: Remove a useless line now that nghttp2 library has moved to /epan |
Wireshark code review |
|
| 11:00 |
[Wireshark-commits] master 1bf4efd: ssl, dtls: convert from tvb_length |
Wireshark code review |
|
| 11:44 |
[Wireshark-commits] master 4e64448: Fix a small typo in the FindChocolatey.cmake module |
Wireshark code review |
|
| 12:28 |
[Wireshark-commits] master 09785b3: I don't see the point of inserting p_proto_data sorted use g_slist_prepend(). While there fix deprecated API. |
Wireshark code review |
|
| 13:34 |
[Wireshark-commits] master a7fb1e5: Fix Uninitialized argument value found by Clang Analyzer |
Wireshark code review |
|
| 13:49 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 14:48 |
[Wireshark-commits] master 96f0585: Quick fix to handle IEPS token. Fix deorecated APIs |
Wireshark code review |
|
| July 11, 2014 |
|---|
| 00:28 |
[Wireshark-commits] master b5d4128: Avoid sign-extending bytes before handing them to <ctype.h> macros. |
Wireshark code review |
|
| 00:29 |
[Wireshark-commits] master-1.12 0ab474c: Avoid sign-extending bytes before handing them to <ctype.h> macros. |
Wireshark code review |
|
| 00:31 |
[Wireshark-commits] master-1.10 caef400: Avoid sign-extending bytes before handing them to <ctype.h> macros. |
Wireshark code review |
|
| 00:43 |
[Wireshark-commits] master 2585e6c: Change comments to reflect current reality. |
Wireshark code review |
|
| 00:44 |
[Wireshark-commits] master d96ff60: As opposed to *loudly* silently? |
Wireshark code review |
|
| 03:20 |
[Wireshark-commits] master 9ed99d5: Strip some trailing whitespace; Fix some indentation; Add editor-modelines as needed. |
Wireshark code review |
|
| 04:29 |
[Wireshark-commits] master c7b45d0: GTK Remote Capturing |
Wireshark code review |
|
| 04:32 |
[Wireshark-commits] master 7248c24: ssl: add missing valid handshake types |
Wireshark code review |
|
| 04:35 |
[Wireshark-commits] master ba6d2e7: ssl: move Certificate handshake dissection to ssl-utils |
Wireshark code review |
|
| 04:36 |
[Wireshark-commits] master 71ebdb6: ssl: move CertificateRequest to ssl-utils |
Wireshark code review |
|
| 04:39 |
[Wireshark-commits] master bc8e095: Update to fix for Bug 6302. There is no need to check block constraints as min length already guarantees this, this also fixes false positives for missing TOS metric blocks |
Wireshark code review |
|
| 04:51 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 04:53 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 05:15 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 07:36 |
[Wireshark-commits] master 423b531: Try to fix the build. |
Wireshark code review |
|
| 07:37 |
[Wireshark-commits] master aa0eb59: Restore some assignments of ti2 that were removed in the proto_tree_add_subtree[_format] conversion |
Wireshark code review |
|
| 09:01 |
[Wireshark-commits] master-1.12 feabf6e: HTTP2: Backport to 1.12 * Add HPACK decompression (add lib nghttp2) * Update to draft-13 |
Wireshark code review |
|
| 13:29 |
[Wireshark-commits] master b3b1f7c: logcat: improve (crash) robustness, improve names |
Wireshark code review |
|
| 13:36 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 13:38 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 15:14 |
[Wireshark-commits] master-1.12 9536540: no need for if(tree) |
Wireshark code review |
|
| 15:15 |
[Wireshark-commits] master-1.12 7f36674: remove duplicate offset=0 |
Wireshark code review |
|
| 15:15 |
[Wireshark-commits] master-1.12 ef90ec1: packet-vnc.c: Improve dissection |
Wireshark code review |
|
| 15:16 |
[Wireshark-commits] master-1.12 3cebc55: packet-vnc.c: Fix a bug in displaying a set of FT_BOOLEAN bit fields (found by checkAPIs). |
Wireshark code review |
|
| 17:55 |
[Wireshark-commits] master 826bca0: GTP: allow empty Data Record Packet IE |
Wireshark code review |
|
| 17:55 |
[Wireshark-commits] master-1.12 615b70a: GTP: allow empty Data Record Packet IE |
Wireshark code review |
|
| 18:12 |
[Wireshark-commits] master-1.10 7f4dbd4: GTP: allow empty Data Record Packet IE |
Wireshark code review |
|
| 20:04 |
[Wireshark-commits] master 14f9434: Remove $Id$ Change-Id: Iae71c6e65000471f251717a172c5f4b812ac1bd3 Reviewed-on: https://code.wireshark.org/review/3011 Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx> |
Wireshark code review |
|
| 20:52 |
[Wireshark-commits] master d1d88f5: Add plumbing for stat commands ("-z ..."). |
Wireshark code review |
|
| 21:11 |
[Wireshark-commits] master e2038e0: Add strlen casts. |
Wireshark code review |
|
| 21:37 |
[Wireshark-commits] master 8044097: Fix the x64 builds after the commit:b3b1f7c3aa2233a147294bad833b748d38fba84d From Change: 2803 |
Wireshark code review |
|
| 22:22 |
[Wireshark-commits] master 6b898e6: Add back -Qunused-arguments for Clang++. |
Wireshark code review |
|
| July 12, 2014 |
|---|
| 00:34 |
[Wireshark-commits] master ea4b2f4: dissectors/llrp: Add support for Impinj's Hub extension |
Wireshark code review |
|
| 00:45 |
[Wireshark-commits] master-1.12 7db5606: ssl/dtls: add support for Raw Public keys |
Wireshark code review |
|
| 00:45 |
[Wireshark-commits] master-1.12 87bcaa1: ssl: move Certificate handshake dissection to ssl-utils |
Wireshark code review |
|
| 12:06 |
[Wireshark-commits] master 9e5e43b: dtls: fix faulty offsets and tvbuff references |
Wireshark code review |
|
| 12:08 |
[Wireshark-commits] master 5fda232: make unit-test suite work out-of-tree |
Wireshark code review |
|
| 14:06 |
[Wireshark-commits] master 55733ea: fix scan_local_interfaces() |
Wireshark code review |
|
| 14:31 |
[Wireshark-commits] master 87895d7: Remove some $Id$ lines |
Wireshark code review |
|
| 17:05 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test |
buildbot-no-reply |
|
| 19:09 |
[Wireshark-commits] master f85b52b: proto_register_zbee_zcl_appl_evtalt: correct formatting |
Wireshark code review |
|
| July 13, 2014 |
|---|
| 15:05 |
[Wireshark-commits] master 082b46f: [Automatic manuf, services and enterprise-numbers update for 2014-07-13] |
Wireshark code review |
|
| 15:08 |
[Wireshark-commits] master-1.12 2c9dd83: [Automatic manuf, services and enterprise-numbers update for 2014-07-13] |
Wireshark code review |
|
| 15:11 |
[Wireshark-commits] master-1.10 3bc742c: [Automatic manuf, services and enterprise-numbers update for 2014-07-13] |
Wireshark code review |
|
| July 14, 2014 |
|---|
| 12:30 |
[Wireshark-commits] master f8f3239: Add default ciphering and integrity algorithms to use for when control messages are not available, e.g. when handing in to a target cell. |
Wireshark code review |
|
| 12:40 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 12:41 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 12:41 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 12:45 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC |
buildbot-no-reply |
|
| 14:02 |
[Wireshark-commits] master 5607620: Fix buildbot issues with commit f8f3239bb03487de1844ab0f6df0ba693322ce4b from change 3016. |
Wireshark code review |
|
| 14:25 |
[Wireshark-commits] master e11db2e: Rename parameter if_index to stop clang warning: |
Wireshark code review |
|
| 15:46 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 15:53 |
[Wireshark-commits] master-1.12 a01be9b: dtls: fix faulty offsets and tvbuff references |
Wireshark code review |
|
| 18:27 |
[Wireshark-commits] master 338369e: Treat CR-LF at the end of a line like LF. |
Wireshark code review |
|
| 18:27 |
[Wireshark-commits] master-1.12 53c01b1e: Treat CR-LF at the end of a line like LF. |
Wireshark code review |
|
| 18:31 |
[Wireshark-commits] master-1.10 2aaed97: Treat CR-LF at the end of a line like LF. |
Wireshark code review |
|
| 19:17 |
[Wireshark-commits] master 06e9b20: Treat CR-LF at the end of a line like LF. |
Wireshark code review |
|
| 19:18 |
[Wireshark-commits] master-1.12 967c209: Treat CR-LF at the end of a line like LF. |
Wireshark code review |
|
| 19:19 |
[Wireshark-commits] master-1.10 bc963b0: Treat CR-LF at the end of a line like LF. |
Wireshark code review |
|
| 23:50 |
[Wireshark-commits] master 52a4f3d: Add application/atom+xml as an XML document type. |
Wireshark code review |
|
| 23:51 |
[Wireshark-commits] master-1.12 a5591dc: Add application/atom+xml as an XML document type. |
Wireshark code review |
|
| 23:52 |
[Wireshark-commits] master-1.10 bf70fc5: Add application/atom+xml as an XML document type. |
Wireshark code review |
|
| July 15, 2014 |
|---|
| 20:16 |
[Wireshark-commits] master 4800894: Cleanup the "export PDU" common code. |
Wireshark code review |
|
| 20:37 |
[Wireshark-commits] master 9ba0a18: Fix up library names when using CMake on Windows |
Wireshark code review |
|
| 21:06 |
[Wireshark-commits] master 9d43634: Make the state variable an enum, and add a case for the IN_SKIP value. |
Wireshark code review |
|
| 22:48 |
[Wireshark-commits] master f9f6fa7: Get rid of cf_reset_state() - it's only called from one place. |
Wireshark code review |
|
| 22:52 |
[Wireshark-commits] master ef1b11f: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 22:53 |
[Wireshark-commits] master 53f597d: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang |
Wireshark code review |
|
| 22:54 |
[Wireshark-commits] master b33f777: Fix Dereference of null pointer found by Clang analyzer |
Wireshark code review |
|
| 22:54 |
[Wireshark-commits] master 9335faa: Moved USB Setup Response Dissection into own function |
Wireshark code review |
|
| 22:55 |
[Wireshark-commits] master 91f627b: MAUSB dissection of control transfer responses |
Wireshark code review |
|
| 22:56 |
[Wireshark-commits] master aebce0b: HTTP2: Fix double free |
Wireshark code review |
|
| 22:56 |
[Wireshark-commits] master-1.12 15b43a1: HTTP2: Fix double free |
Wireshark code review |
|
| 22:58 |
[Wireshark-commits] master 36548d7: Fix Argument with 'nonnull' attribute passed null found by Clang |
Wireshark code review |
|
| 22:58 |
[Wireshark-commits] master 8982e87: Looks like this file is completely outdated - at least the problems it mentions are. |
Wireshark code review |
|
| 23:07 |
[Wireshark-commits] master aecbb98: ssl: unify common Hello dissection to ssl-utils |
Wireshark code review |
|
| 23:07 |
[Wireshark-commits] master 2c772e3: ssl: move decoder init from ClientKeyExchange to ChangeCipherSpec |
Wireshark code review |
|
| 23:23 |
[Wireshark-commits] master 7344cfc: Have buffer_free() null out the buffer data pointer. |
Wireshark code review |
|
| 23:23 |
[Wireshark-commits] master-1.12 21bf67a: Have buffer_free() null out the buffer data pointer. |
Wireshark code review |
|
| 23:25 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 23:28 |
[Wireshark-commits] master 61ac815: No more README.irix. |
Wireshark code review |
|
| 23:43 |
[Wireshark-commits] master d4dab16: Only one buffer.c, please. |
Wireshark code review |
|
| 23:44 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 23:52 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 23:55 |
[Wireshark-commits] master-1.12 445abfa: Only one buffer.c, please. |
Wireshark code review |
|
| July 16, 2014 |
|---|
| 00:04 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 00:14 |
[Wireshark-commits] master 28971b2: Squelch a warning. |
Wireshark code review |
|
| 00:15 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 00:15 |
[Wireshark-commits] master-1.12 663b13b: Squelch a warning. |
Wireshark code review |
|
| 00:16 |
[Wireshark-commits] master-1.10 0e5a975: Squelch a warning. |
Wireshark code review |
|
| 00:17 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 00:23 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5 x86 |
buildbot-no-reply |
|
| 00:23 |
[Wireshark-commits] master b720f08: Don't use __func__, use G_STRFUNC. |
Wireshark code review |
|
| 00:57 |
[Wireshark-commits] master f862eaa: "Export PDUs to File" pops up a dialog, so put "..." after it. |
Wireshark code review |
|
| 00:57 |
[Wireshark-commits] master-1.12 b7d81fa: "Export PDUs to File" pops up a dialog, so put "..." after it. |
Wireshark code review |
|
| 01:06 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86 |
buildbot-no-reply |
|
| 01:10 |
[Wireshark-commits] master bd30abf: The plural is "PDUs", not "PDU:s". |
Wireshark code review |
|
| 01:11 |
[Wireshark-commits] master-1.12 5446fea: The plural is "PDUs", not "PDU:s". |
Wireshark code review |
|
| 01:27 |
[Wireshark-commits] master fae3615: Move the monitor-for-interface-list-changes stuff to the caputils library. |
Wireshark code review |
|
| 01:57 |
[Wireshark-commits] master d8cff57: Allow expert info to show only items in the display filter. |
Wireshark code review |
|
| 01:58 |
[Wireshark-commits] master 1387f54: Check for __func__ in checkAPIs.pl |
Wireshark code review |
|
| 02:01 |
[Wireshark-commits] master 4d71fb7: Mark unused parameter as such |
Wireshark code review |
|
| 02:28 |
[Wireshark-commits] master 0e0d01d: Allow the interface monitor routines to be called from C++. |
Wireshark code review |
|
| 03:27 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 03:41 |
[Wireshark-commits] master 2dad308: Reflect the move of the buffer_ routines to libwsutil. |
Wireshark code review |
|
| 04:08 |
[Wireshark-commits] master-1.12 1a92fab: Allow expert info to show only items in the display filter. |
Wireshark code review |
|
| 04:12 |
[Wireshark-commits] master-1.10 a8686df: Allow expert info to show only items in the display filter. |
Wireshark code review |
|
| 04:19 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5 x86 |
buildbot-no-reply |
|
| 04:19 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.6 x64 |
buildbot-no-reply |
|
| 06:53 |
[Wireshark-commits] master 024c002: TLS: Update to the final RFC (7301) for ALPN |
Wireshark code review |
|
| 11:32 |
[Wireshark-commits] master 09cb981: Fix regression related to OSPF related enum order definitions |
Wireshark code review |
|
| 12:11 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 12:36 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 13:23 |
[Wireshark-commits] master-1.12 3abb0f0: Fix regression related to OSPF related enum order definitions |
Wireshark code review |
|
| 14:13 |
[Wireshark-commits] master 1b8c4ba: Fix assertion error when no header field was decompressed |
Wireshark code review |
|
| 14:14 |
[Wireshark-commits] master-1.12 3c75739: Fix assertion error when no header field was decompressed |
Wireshark code review |
|
| 17:45 |
[Wireshark-commits] [wireshark] reference refs/changes/56/2956 created (now 6a3f700) |
Wireshark code review |
|
| July 17, 2014 |
|---|
| 15:46 |
[Wireshark-commits] master ed043d7: When DNP3 heuristics are disabled, relax the conditions on accepting a packet as DNP3. |
Wireshark code review |
|
| 16:12 |
[Wireshark-commits] master b744f0e: Add an Application Id. |
Wireshark code review |
|
| 16:28 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 22:18 |
[Wireshark-commits] master e05a884: Try to make tap operations in the Qt UI more responsive. |
Wireshark code review |
|
| 23:47 |
[Wireshark-commits] master 3e7ed3d: Escape some characters like \n when appending text |
Wireshark code review |
|
| July 18, 2014 |
|---|
| 02:51 |
[Wireshark-commits] master 1d079fd: ssl-utils: change some references from ietf drafts to rfcs |
Wireshark code review |
|
| 03:38 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 05:34 |
[Wireshark-commits] master e95083d: Support of draft-ietf-idr-flow-spec-v6 and some cosmetic improvments |
Wireshark code review |
|
| 05:35 |
[Wireshark-commits] master 7c3652d: Split LBMR tap into 5 separate taps. Make the associated tap data use fixed-length fields. The idea is to allow user-written tap listeners easier access to the tap data. Also correct the conditions (in packet-lbmc.c) under which a subdissector would be called, if present. |
Wireshark code review |
|
| 08:55 |
[Wireshark-commits] master 4a8b688: Add casts to make the buildbot happy. |
Wireshark code review |
|
| 19:55 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis |
buildbot-no-reply |
|
| 20:05 |
[Wireshark-commits] master 01359be: Add better assertions for comparing integers. |
Wireshark code review |
|
| 20:10 |
[Wireshark-commits] master 23f2571: DNS: Add new opcode EDNS EXPIRE (9) for EDNS options (RFC7314) |
Wireshark code review |
|
| 20:11 |
[Wireshark-commits] master deb1d8d: WebSocket: increase max unmask payload size to 256K and indicate that packet is truncated is going above the new limit |
Wireshark code review |
|
| 20:13 |
[Wireshark-commits] master e28a8ff: Add some expert info to the MAC Control dissector |
Wireshark code review |
|
| 20:41 |
[Wireshark-commits] master-1.12 331a6ca: WebSocket: increase max unmask payload size to 256K and indicate that packet is truncated is going above the new limit |
Wireshark code review |
|
| 20:48 |
[Wireshark-commits] master-1.10 cb36560: WebSocket: increase max unmask payload size to 256K and indicate that packet is truncated is going above the new limit |
Wireshark code review |
|
| 20:50 |
[Wireshark-commits] master 4b72069: Fix install_desktop_files non-portability and add out-of-tree support. |
Wireshark code review |
|
| 20:51 |
[Wireshark-commits] master-1.12 dc00875: Fix install_desktop_files non-portability and add out-of-tree support. |
Wireshark code review |
|
| 20:51 |
[Wireshark-commits] master-1.10 9cf8930: Fix install_desktop_files non-portability and add out-of-tree support. |
Wireshark code review |
|
| July 19, 2014 |
|---|
| 00:45 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis |
buildbot-no-reply |
|
| 00:55 |
[Wireshark-commits] master 5cc2ab7: HTTP2: Update to nghttp2 lib 0.5.0 |
Wireshark code review |
|
| 00:55 |
[Wireshark-commits] master 644c1d5: Add extern "C", to let this be used from C++. |
Wireshark code review |
|
| 01:04 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 01:05 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 01:05 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 01:06 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 01:08 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC |
buildbot-no-reply |
|
| 01:12 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 01:15 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 01:17 |
[Wireshark-commits] master 4a182d4: Revert part of 5cc2ab74af486611def7bcc14105c1a0257b41de |
Wireshark code review |
|
| 06:39 |
[Wireshark-commits] master bf514a5: Add casts to squelch compiler warnings. |
Wireshark code review |
|
| 07:22 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 07:24 |
[Wireshark-commits] master f724cae: Only ABI-check strncasecmp.h if strncasecmp() is part of the API/ABI. |
Wireshark code review |
|
| 07:24 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 12:19 |
[Wireshark-commits] master 831c1f2: add H.265 stream type |
Wireshark code review |
|
| 12:20 |
[Wireshark-commits] master 6885cc7: use gboolean for detected_drop |
Wireshark code review |
|
| 12:20 |
[Wireshark-commits] master 7d0ad3f: no need to initialize these pointers |
Wireshark code review |
|
| 12:21 |
[Wireshark-commits] master c21a8a7: remove some more unnecessary initializations |
Wireshark code review |
|
| 12:23 |
[Wireshark-commits] master-1.12 90bb39f: add H.265 stream type |
Wireshark code review |
|
| 12:56 |
[Wireshark-commits] master 3023911: fix bug 9100 |
Wireshark code review |
|
| 13:25 |
[Wireshark-commits] master-1.12 f9f1247: fix bug 9100 |
Wireshark code review |
|
| 14:21 |
[Wireshark-commits] master 8e4ae89: simplify the tree handling a bit |
Wireshark code review |
|
| 14:21 |
[Wireshark-commits] master 65873a9: add editor modelines reformat |
Wireshark code review |
|
| 14:22 |
[Wireshark-commits] master 18dfb13: remove the NULL check in APPEND_BOOLEAN_FLAG |
Wireshark code review |
|
| 14:22 |
[Wireshark-commits] master ab2922b: simplify APPEND_OUI_NAME |
Wireshark code review |
|
| 14:22 |
[Wireshark-commits] master 450f491: use proto_tree_add_item() |
Wireshark code review |
|
| July 20, 2014 |
|---|
| 00:20 |
[Wireshark-commits] master 320c4f0: va_list can't be NULL on ARM. |
Wireshark code review |
|
| 00:21 |
[Wireshark-commits] master-1.12 8dc5330: va_list can't be NULL on ARM. |
Wireshark code review |
|
| 13:16 |
[Wireshark-commits] master 696cb6c: Use forward slashes in paths to runlex.sh |
Wireshark code review |
|
| 15:05 |
[Wireshark-commits] master bb53fba: [Automatic manuf, services and enterprise-numbers update for 2014-07-20] |
Wireshark code review |
|
| 15:08 |
[Wireshark-commits] master-1.12 fd12a88: [Automatic manuf, services and enterprise-numbers update for 2014-07-20] |
Wireshark code review |
|
| 15:11 |
[Wireshark-commits] master-1.10 490cf7c: [Automatic manuf, services and enterprise-numbers update for 2014-07-20] |
Wireshark code review |
|
| 16:20 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 18:02 |
[Wireshark-commits] master b1532b2: start support for the Japanese language in the Qt version |
Wireshark code review |
|
| 18:36 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 19:18 |
[Wireshark-commits] master 3a451a8: Add qtshark_ja_JP.qm to the list of .qm files we distribute. |
Wireshark code review |
|
| 22:14 |
[Wireshark-commits] master a3f7d19: Get rid of #if 0'ed out includes of capture-pcap-util.h. |
Wireshark code review |
|
| 22:33 |
[Wireshark-commits] master e91121e: Change a comment to be slightly easier to read Reorder code to have all toplevel code in 'main' |
Wireshark code review |
|
| 23:40 |
[Wireshark-commits] master 622f06b: WIRESHARK_TARGET_PLATFORM is only used inside --download code path: Use it only there. Update comments wrt DOWNLOAD_PREFIX Remove trailing / at end of DOWNLOAD_PREFIX |
Wireshark code review |
|
| July 21, 2014 |
|---|
| 00:22 |
[Wireshark-commits] master c90b642: Pass the download tag as an argument to win-setup.sh instead as an enviroment variable |
Wireshark code review |
|
| 01:04 |
[Wireshark-commits] master 075ac2e: Obsolete tools/winXX-setup.sh: - Move DOWNLOAD_TAG into config.nmake - Call win-setup.sh directly instead of winXX-setup.sh - TODO: Remove tools/winXX-setup.sh files |
Wireshark code review |
|
| 01:10 |
[Wireshark-commits] master 494092a: One more place with win32-setup.sh -> win-setup.sh |
Wireshark code review |
|
| 01:13 |
[Wireshark-commits] master 56a2411: Remove tools/win32-setup.sh and tools/win64-setup.sh |
Wireshark code review |
|
| 09:39 |
[Wireshark-commits] master 13288b0: Add auth plugin to server greeting info |
Wireshark code review |
|
| 09:59 |
[Wireshark-commits] master bcf0ea3: display unused bytes as raw bytes not as ASCII string |
Wireshark code review |
|
| 09:59 |
[Wireshark-commits] master d52f4d5: simplify the tree handling a bit |
Wireshark code review |
|
| 15:31 |
[Wireshark-commits] master 700a474: Start converting the User's Guide to AsciiDoc. |
Wireshark code review |
|
| 18:33 |
[Wireshark-commits] master 16daf0c: Add a warning that not all command line options are implemented |
Wireshark code review |
|
| 19:07 |
[Wireshark-commits] master 48986f4: Make the Qt version update displays when interfaces appear or disappear. |
Wireshark code review |
|
| 22:22 |
[Wireshark-commits] master-1.12 dcf0717: Don't put hyphens in the rc's versions. |
Wireshark code review |
|
| 23:15 |
[Wireshark-commits] master d81a34c: Have the interface "tree" directly connect to ifListChanged. |
Wireshark code review |
|
| 23:19 |
[Wireshark-commits] master 59ef97d: [WIP] Add a conversation dialog. |
Wireshark code review |
|
| 23:31 |
[Wireshark-commits] master c7a2c89: Rename ifListChanged to localInterfaceListChanged. |
Wireshark code review |
|
| July 22, 2014 |
|---|
| 00:07 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 00:15 |
[Wireshark-commits] master fdff1b3: Don't connect to non-existent slots. |
Wireshark code review |
|
| 00:31 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 00:43 |
[Wireshark-commits] master f229aed: Our users are not particpants in a comedy sketch. |
Wireshark code review |
|
| 02:03 |
[Wireshark-commits] master dacb1f6: better visibility for vx11 |
Wireshark code review |
|
| 02:05 |
[Wireshark-commits] master 7dcb1d7: Update MySQL Capability flags |
Wireshark code review |
|
| 11:04 |
[Wireshark-commits] master faf3261: Makes the RTP Player graphs work with GTK3 |
Wireshark code review |
|
| 12:10 |
[Wireshark-commits] master-1.12 88834bd: Makes the RTP Player graphs work with GTK3 |
Wireshark code review |
|
| 13:56 |
[Wireshark-commits] master 2029c41: Fixed C++ style comment |
Wireshark code review |
|
| 16:20 |
[Wireshark-commits] master 7bc24ed: Add back a 'dummy' comment I removed with commit e91121e1435d97c92 |
Wireshark code review |
|
| 17:17 |
[Wireshark-commits] master-1.12 04e4136: Build 1.12.0rc3. |
Wireshark code review |
|
| 17:19 |
[Wireshark-commits] [wireshark] annotated tag v1.12.0rc3 created (now e63ab86) |
Wireshark code review |
|
| 18:37 |
[Wireshark-commits] master-1.12 e14d5b6: Fix rc version. |
Wireshark code review |
|
| 18:47 |
[Wireshark-commits] [wireshark] annotated tag v1.12.0rc3 deleted (was e63ab86) |
Wireshark code review |
|
| 18:47 |
[Wireshark-commits] [wireshark] annotated tag v1.12.0rc3 created (now 3641f64) |
Wireshark code review |
|
| 18:51 |
[Wireshark-commits] master 4261109: Don't return an error string for NO_INTERFACES_FOUND. |
Wireshark code review |
|
| 19:50 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 20:29 |
[Wireshark-commits] master-1.12 d11b733: 1.12.0rc3 → 1.12.0rc4 |
Wireshark code review |
|
| 20:41 |
[Wireshark-commits] master-1.12 0da9639: Don't return an error string for NO_INTERFACES_FOUND. |
Wireshark code review |
|
| 20:47 |
[Wireshark-commits] master-1.10 eed3850: Don't return an error string for NO_INTERFACES_FOUND. |
Wireshark code review |
|
| 23:53 |
[Wireshark-commits] master f6ce0cd: Get rid of NO_INTERFACES_FOUND - it's not an error. |
Wireshark code review |
|
| 23:57 |
[Wireshark-commits] master 4028f56: Clean up indentation (get rid of tabs). |
Wireshark code review |
|
| July 23, 2014 |
|---|
| 00:00 |
[Wireshark-commits] master 397ce1f: Clean up indentation (consistent 4-space indentation). |
Wireshark code review |
|
| 09:08 |
[Wireshark-commits] master a760a7d: Clean up indentation (consistent two-space indentation). |
Wireshark code review |
|
| 10:31 |
[Wireshark-commits] master ccbf373: Logcat: Add support for conversion from Exported PDU |
Wireshark code review |
|
| 10:40 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 11:16 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 15:23 |
[Wireshark-commits] master 26e4b94: Fix decoding of PPP frames from Redback Smartedge trace |
Wireshark code review |
|
| 15:24 |
[Wireshark-commits] master 822d0ca: Add dissecting of IPv6 in Redback Smartedge Captures |
Wireshark code review |
|
| 15:44 |
[Wireshark-commits] master fbcfe6e: Fix email address and product name in Redback dissector |
Wireshark code review |
|
| 17:08 |
[Wireshark-commits] master aa09fea: ssl, dtls: move ServerHello to ssl-utils |
Wireshark code review |
|
| 17:09 |
[Wireshark-commits] master ee231c5: ssl, dtls: move ClientHello to ssl-utils |
Wireshark code review |
|
| 17:09 |
[Wireshark-commits] master 057ded8: ssl-utils: stop exporting some symbols |
Wireshark code review |
|
| 17:44 |
[Wireshark-commits] master ae64e09: Add cast to satisfy win7 buildbot |
Wireshark code review |
|
| 17:48 |
[Wireshark-commits] master d610ef2: Add some #includes to satisfy check-abi |
Wireshark code review |
|
| 19:55 |
[Wireshark-commits] master 90e46f4: Fix (-W)documentation error found by Clang |
Wireshark code review |
|
| 20:50 |
[Wireshark-commits] master 5e3b044: ssl, dtls: move Session Ticket to ssl-utils |
Wireshark code review |
|
| 20:54 |
[Wireshark-commits] master 73c1810: MySQL: Add Client can handle expried passwords extended Capability |
Wireshark code review |
|
| July 24, 2014 |
|---|
| 05:29 |
[Wireshark-commits] master fc983cf: ssl, dtls: move Finished dissection to ssl-utils |
Wireshark code review |
|
| 05:33 |
[Wireshark-commits] master 2944d8b: ssl: clarify meaning of StringInfo, cleanup PRFs, master_secret |
Wireshark code review |
|
| 05:42 |
[Wireshark-commits] master c025152: Micro-optimize tvbuff: |
Wireshark code review |
|
| 06:20 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 06:26 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 19:11 |
[Wireshark-commits] master 2c1b673: IMAP: fix mixed indent (use 2spaces) |
Wireshark code review |
|
| 19:59 |
[Wireshark-commits] master 476f49c: dissect the MP4 hdlr box |
Wireshark code review |
|
| 20:00 |
[Wireshark-commits] master 7d219fd: dissect the MP4 dref box |
Wireshark code review |
|
| 20:00 |
[Wireshark-commits] master fb9851e: dissect the MP4 url box |
Wireshark code review |
|
| 20:01 |
[Wireshark-commits] master 0b15ec8: start dissecting the MP4 stsd box |
Wireshark code review |
|
| 20:01 |
[Wireshark-commits] master cca0fd3: add the flags to all FullBoxes |
Wireshark code review |
|
| 23:16 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 23:18 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| July 25, 2014 |
|---|
| 00:28 |
[Wireshark-commits] master 5688c8a: Add the default directores used by the Qt Online Installer for Qt 5.3. |
Wireshark code review |
|
| 00:34 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 02:30 |
[Wireshark-commits] master 05c0630: Make HTML Help steps compliant with newer Nmakes. |
Wireshark code review |
|
| 02:58 |
[Wireshark-commits] master ebe7132: Remove valgrind suppression for old zlib version |
Wireshark code review |
|
| 02:59 |
[Wireshark-commits] master 0501465: Fixing a bug in add_ff_action_public_fields(), by removing the start argument and defining it inside the function. |
Wireshark code review |
|
| 03:00 |
[Wireshark-commits] master 35b4487: Handle empty interface lists when the list changes. |
Wireshark code review |
|
| 07:45 |
[Wireshark-commits] master 9ccf2e0: Make Capture -> Refresh Interfaces work. |
Wireshark code review |
|
| 11:45 |
[Wireshark-commits] master 7701650: Update documentaion for p_(add|get)_proto_data(); There's been a 'key' arg for a while. |
Wireshark code review |
|
| 11:51 |
[Wireshark-commits] master 788ff15: Empty proto_reg_handoff_* are not needed, remove some. |
Wireshark code review |
|
| 19:54 |
[Wireshark-commits] master c3e42cc: OptoMMP Dissector |
Wireshark code review |
|
| 21:26 |
[Wireshark-commits] master 0492921: Replace lseek/fstat by ws_lseek64/ws_fstat64 |
Wireshark code review |
|
| 22:49 |
[Wireshark-commits] master ab9dc4f: Don't use capture_interface_list() in this dialog. |
Wireshark code review |
|
| 23:28 |
[Wireshark-commits] master 251ee71: Add OptoMMP to the Release Notes and NEWS. Add its author to AUTHORS. |
Wireshark code review |
|
| July 26, 2014 |
|---|
| 01:03 |
[Wireshark-commits] master 507d07e: Allow severity levels of expert info items to be configured by the user. |
Wireshark code review |
|
| 10:10 |
[Wireshark-commits] wireshark-win32-libs rev 450: / /trunk/packages/: lua-5.2.3_Win32_dll12_lib.zip lua5_1_4_Win32_dll6_lib.zip /trunk/: README.txt |
pascal |
|
| 10:12 |
[Wireshark-commits] wireshark-win64-libs rev 404: / /trunk/packages/: lua-5.1.4_Win64_dll10_lib.zip lua-5.2.3_Win64_dll12_lib.zip lua5_1_4_Win64_dll8_lib.zip lua5_1_4_Win64_dll9_lib.zip /trunk/: ... |
pascal |
|
| 11:20 |
[Wireshark-commits] wireshark-win32-libs rev 451: /tags/2014-07-26/ /tags/2014-07-26/: README.txt README.txt /tags/2014-07-26/packages/: lua-5.2.3_Win32_dll12_lib.zip lua5_1_4_Win32_dll6_lib.zip |
pascal |
|
| 11:22 |
[Wireshark-commits] wireshark-win64-libs rev 405: /tags/2014-07-26/ /tags/2014-07-26/: README.txt README.txt /tags/2014-07-26/packages/: lua-5.1.4_Win64_dll10_lib.zip lua-5.2.3_Win64_dll12_lib.zip ... |
pascal |
|
| 17:22 |
[Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test |
buildbot-no-reply |
|
| 20:59 |
[Wireshark-commits] master 31ecdf5: Refactor "common" Conversation table functionality. |
Wireshark code review |
|
| 22:34 |
[Wireshark-commits] master 2b71946: Download and install a binary package of CMake from Kitware. |
Wireshark code review |
|
| July 27, 2014 |
|---|
| 01:40 |
[Wireshark-commits] master d95d775: Fix yet another openflow underflow issue. |
Wireshark code review |
|
| 01:49 |
[Wireshark-commits] master-1.12 7c8d408: Fix yet another openflow underflow issue. |
Wireshark code review |
|
| 15:05 |
[Wireshark-commits] master 8762c78: [Automatic manuf, services and enterprise-numbers update for 2014-07-27] |
Wireshark code review |
|
| 15:08 |
[Wireshark-commits] master-1.12 c3a09d2: [Automatic manuf, services and enterprise-numbers update for 2014-07-27] |
Wireshark code review |
|
| 15:11 |
[Wireshark-commits] master-1.10 6acb8d5: [Automatic manuf, services and enterprise-numbers update for 2014-07-27] |
Wireshark code review |
|
| 16:34 |
[Wireshark-commits] master b9183b9: Use a compatible Lua library when building with MSVC2013 |
Wireshark code review |
|
| 17:41 |
[Wireshark-commits] master ec08f34: Added function dnp3_header_check() to check the validity of a DNP3 packet as far as possible, called from both dissect_dnp3_tcp and dissect_dnp3_udp. |
Wireshark code review |
|
| 19:10 |
[Wireshark-commits] master 4658109: Fix incorrect whitespace. Why this wasn't spotted during review? |
Wireshark code review |
|
| 19:55 |
[Wireshark-commits] master 8aa0507: Add some scripts to fix up Qt's OS X binary packages. |
Wireshark code review |
|
| 20:11 |
[Wireshark-commits] master 8807e6b: Fix quoting. |
Wireshark code review |
|
| 20:13 |
[Wireshark-commits] master 2034c3e: Fix the path to the "fix one .pc file" script. |
Wireshark code review |
|
| 20:14 |
[Wireshark-commits] master 5b1106d: Remove printing done for debugging/test purposes. |
Wireshark code review |
|
| 20:32 |
[Wireshark-commits] master dacf6e4: Don't fail if unmounting the CMake disk image fails. |
Wireshark code review |
|
| 20:47 |
[Wireshark-commits] wireshark-win32-libs rev 452: /trunk/packages/ /trunk/packages/: lua-5.2.3_Win32_dll12_lib.zip |
pascal |
|
| 20:48 |
[Wireshark-commits] wireshark-win64-libs rev 406: /trunk/packages/ /trunk/packages/: lua-5.2.3_Win64_dll12_lib.zip |
pascal |
|
| 21:32 |
[Wireshark-commits] master e21c429: Add PortableApps temporary files to .gitignore |
Wireshark code review |
|
| 21:41 |
[Wireshark-commits] wireshark-win32-libs rev 453: /tags/2014-07-27/ /tags/2014-07-27/packages/: lua-5.2.3_Win32_dll12_lib.zip lua-5.2.3_Win32_dll12_lib.zip |
pascal |
|
| 21:43 |
[Wireshark-commits] wireshark-win64-libs rev 407: /tags/2014-07-27/ /tags/2014-07-27/packages/: lua-5.2.3_Win64_dll12_lib.zip lua-5.2.3_Win64_dll12_lib.zip |
pascal |
|
| 22:02 |
[Wireshark-commits] master 34e413f: Make value_string_ext const-correct. |
Wireshark code review |
|
| July 28, 2014 |
|---|
| 05:13 |
[Wireshark-commits] master 6ef2ad2: Fix MSVC2013 Lua package (previous one was linked against MSVC2012) |
Wireshark code review |
|
| 12:03 |
[Wireshark-commits] master 52629d8: Download the right User Guide... |
Wireshark code review |
|
| 15:27 |
[Wireshark-commits] master 083d6e7: Add a few mor application Ids |
Wireshark code review |
|
| 17:36 |
[Wireshark-commits] master ff01321: Sort diameter.applicationId fix a typo. |
Wireshark code review |
|
| 17:39 |
[Wireshark-commits] master 3a9f126: config.nmake: Do some minor changes (mostly in comments). |
Wireshark code review |
|
| 18:27 |
[Wireshark-commits] master 0f85608: Use wmem for application Ids Remove soft deprecated APIs |
Wireshark code review |
|
| 18:32 |
[Wireshark-commits] master 9ce04cb: Fix download of 3rd party packages when WIRESHARK_TARGET_PLATFORM environment variable is not explicitly set |
Wireshark code review |
|
| 18:40 |
[Wireshark-commits] master 84edd1a: (Trivial) config.nmake: fix a spelling error and add some punctuation. |
Wireshark code review |
|
| 21:57 |
[Wireshark-commits] master c6a7190: From 竹下 恵 (Megumi Takeshita) update the japanese translation for the Qt user interface |
Wireshark code review |
|
| 21:58 |
[Wireshark-commits] master 82efb21: add 恵 to the AUTHORS file |
Wireshark code review |
|
| July 29, 2014 |
|---|
| 01:26 |
[Wireshark-commits] master 75c7b15: Bluetooth: Fix OBEX over L2CAP detection |
Wireshark code review |
|
| 01:43 |
[Wireshark-commits] master 0aa4cb2: Fix possible uninitialized session key in netlogin auth |
Wireshark code review |
|
| 01:43 |
[Wireshark-commits] master-1.12 887c8e8: Fix possible uninitialized session key in netlogin auth |
Wireshark code review |
|
| 01:45 |
[Wireshark-commits] master 4a1bd42: Bug 10302 - BGP attribute AIGP (draft-ietf-idr-aigp) not decoded - Fix |
Wireshark code review |
|
| 01:49 |
[Wireshark-commits] master eece1c5: EPL: Fix for Write Multiple by index |
Wireshark code review |
|
| 01:50 |
[Wireshark-commits] master b99d964: Document some new features (and API changes) since 1.12.0. |
Wireshark code review |
|
| 01:51 |
[Wireshark-commits] master 3db115a: Add a couple more dissector authors. |
Wireshark code review |
|
| 01:53 |
[Wireshark-commits] master 0272b9c: Fix heap-use-after-free via setlocale |
Wireshark code review |
|
| 01:53 |
[Wireshark-commits] master-1.12 5a8eab1: Fix heap-use-after-free via setlocale |
Wireshark code review |
|
| 01:56 |
[Wireshark-commits] master d786ed8: Remove unused variable |
Wireshark code review |
|
| 09:31 |
[Wireshark-commits] master 3b11d22: Remove duplicated entry for AVP 258 Auth-Application-Id from HP.xml it was overiding the correct one from dictionary.xml |
Wireshark code review |
|
| 13:36 |
[Wireshark-commits] master dff0382: Ensure that QT5_BASE_DIR is known by QtShark.pro |
Wireshark code review |
|
| 14:41 |
[Wireshark-commits] master cc0f354: Fix Argument with 'nonnull' attribute passed null found by Clang |
Wireshark code review |
|
| 16:02 |
[Wireshark-commits] master 54d5030: (trivial) modify, indent a comment |
Wireshark code review |
|
| 21:48 |
[Wireshark-commits] master 5dd7cfe: remove unnecessary return; statement |
Wireshark code review |
|
| 21:49 |
[Wireshark-commits] master 9d0e4f6: don't add nonprinting \000 characters to tftp option strings |
Wireshark code review |
|
| 23:24 |
[Wireshark-commits] master 9a897d5: Use windeployqt with NSIS. |
Wireshark code review |
|
| July 30, 2014 |
|---|
| 00:28 |
[Wireshark-commits] master 1f08f87: Dont force qt-dll-manifest.txt. |
Wireshark code review |
|
| 01:47 |
[Wireshark-commits] master 50c10c0: The Visual C++ 2013 redistributable uses /quiet instead of /q. |
Wireshark code review |
|
| 01:53 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC |
buildbot-no-reply |
|
| 02:56 |
[Wireshark-commits] master 054bff4: Fix up some white space. |
Wireshark code review |
|
| 09:10 |
[Wireshark-commits] master 82bb800: GED125: remove a wrong comment regarding the default TCP port |
Wireshark code review |
|
| 15:45 |
[Wireshark-commits] master ede5a9d: Convert tvb_get_ptr buffer access macros to use much safer tvb access macros. |
Wireshark code review |
|
| 15:45 |
[Wireshark-commits] master 54777bf: Fix cmake build for portaudio V18 |
Wireshark code review |
|
| 16:12 |
[Wireshark-commits] master dcf6d44: Apply refactored "conversation" (tap) data to TShark. |
Wireshark code review |
|
| 16:25 |
[Wireshark-commits] master 9ed85d1: Fix use of uninitialized field |
Wireshark code review |
|
| 16:26 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 16:30 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 |
buildbot-no-reply |
|
| 16:32 |
[Wireshark-commits] master 5894b55: fix encodingmask of DiagnosticInfo |
Wireshark code review |
|
| 16:39 |
[Wireshark-commits] master 482dcf8: Remove empty variable SHARK_COMMON_CAPTURE_SRC. It's not present for the other build systems as well. Small whitespace fix. |
Wireshark code review |
|
| 17:06 |
[Wireshark-commits] master 8d05e85: Fix the build: add a few more G_GINT64_MODIFIER's when printing 64-bit numbers. |
Wireshark code review |
|
| 17:24 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 |
buildbot-no-reply |
|
| 17:55 |
[Wireshark-commits] master-1.12 974fdcb: fix encodingmask of DiagnosticInfo |
Wireshark code review |
|
| 17:55 |
[Wireshark-commits] master-1.10 8596593: fix encodingmask of DiagnosticInfo |
Wireshark code review |
|
| 18:07 |
[Wireshark-commits] master 304388a: Install our Qt DLL directories recursively. |
Wireshark code review |
|
| 18:22 |
[Wireshark-commits] master e6a2fab: Fix dist. |
Wireshark code review |
|
| 20:51 |
[Wireshark-commits] master-1.10 a1785a9: Convert tvb_get_ptr buffer access macros to use much safer tvb access macros. |
Wireshark code review |
|
| 20:51 |
[Wireshark-commits] master-1.12 13c5737: Convert tvb_get_ptr buffer access macros to use much safer tvb access macros. |
Wireshark code review |
|
| 20:53 |
[Wireshark-commits] master-1.10 cdb8710: catapult, irda: Fix ASAN crashes due to buffer underrun |
Wireshark code review |
|
| 20:55 |
[Wireshark-commits] master-1.12 9977a81: EPL: Fix for Write Multiple by index |
Wireshark code review |
|
| 23:08 |
[Wireshark-commits] master 3f0430d: Add libgpg-error6-0 to the GCRYPT_ERROR_LIBRARY search list. |
Wireshark code review |
|
| 23:42 |
[Wireshark-commits] master 4d90d6e: Add some files under asn1 to the distribution. |
Wireshark code review |
|
| July 31, 2014 |
|---|
| 00:41 |
[Wireshark-commits] master-1.10 015aa86: Update release notes and ChangeLog. |
Wireshark code review |
|
| 01:30 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 |
buildbot-no-reply |
|
| 04:31 |
[Wireshark-commits] master 791d93a: Add more files to the distribution. |
Wireshark code review |
|
| 04:40 |
[Wireshark-commits] master 0a12f7d: addr_resolution_dlg.c: Fix crash when 'Statistics ! Show address resolution' is invoked. |
Wireshark code review |
|
| 04:41 |
[Wireshark-commits] master 278b762: addr_resolution_dlg.c: "OK" button should *do* something: treat as cxl. |
Wireshark code review |
|
| 04:43 |
[Wireshark-commits] master-1.12 0fd61b1: addr_resolution_dlg.c: Fix crash when 'Statistics ! Show address resolution' is invoked. |
Wireshark code review |
|
| 04:44 |
[Wireshark-commits] master-1.12 ed24269: addr_resolution_dlg.c: "OK" button should *do* something: treat as cxl. |
Wireshark code review |
|
| 04:45 |
[Wireshark-commits] master 5dd83af: Add some missing CMake files to the distribution. |
Wireshark code review |
|
| 05:56 |
[Wireshark-commits] master 54c55bb: Add a missed -template.h file |
Wireshark code review |
|
| 07:43 |
[Wireshark-commits] master 067beb0: Add a bunch of missing files to the distribution. |
Wireshark code review |
|
| 07:53 |
[Wireshark-commits] master 7e2dc50: Nobody uses packet-t125.h, so don't bother building it, and delete it. |
Wireshark code review |
|
| 08:27 |
[Wireshark-commits] master 7f3d97c: Include the gnm dissector. |
Wireshark code review |
|
| 08:30 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 08:33 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 08:55 |
[Wireshark-commits] master 3ac49be9: Add more files to the release tarball. |
Wireshark code review |
|
| 08:57 |
[Wireshark-commits] master acea064: Missing end-of-line backslash. |
Wireshark code review |
|
| 11:06 |
[Wireshark-commits] master a1032fa: Convert hf_packetbb_error filter (packetbb.error) to expert info. |
Wireshark code review |
|
| 11:08 |
[Wireshark-commits] master 7939d32: ssl, dtls: simplify keyfile handling |
Wireshark code review |
|
| 11:09 |
[Wireshark-commits] master a69a63f: ssl: fix SSL keylog file live-capture use case |
Wireshark code review |
|
| 13:21 |
[Wireshark-commits] master 3762440: cmake also needs to learn to build SVR4 packages. |
Wireshark code review |
|
| 14:39 |
[Wireshark-commits] master a91dbf7: proto_add_subtree_format(): initialize tree_item to 'tree' rather than NULL. |
Wireshark code review |
|
| 18:12 |
[Wireshark-commits] master-1.12 d698a6b: Use the "release" splash image. |
Wireshark code review |
|
| 18:36 |
[Wireshark-commits] master 8531f88: Include OS X installer dmgs as a package type we need to support. |
Wireshark code review |
|
| 18:38 |
[Wireshark-commits] master b98537a: We need to support building against an SDK on OS X. |
Wireshark code review |
|
| 18:39 |
[Wireshark-commits] master 9505d3a: Need to make Windows installer packages as well. |
Wireshark code review |
|
| 18:42 |
[Wireshark-commits] master-1.12 4fab41a: Build 1.12.0. |
Wireshark code review |
|
| 18:44 |
[Wireshark-commits] [wireshark] annotated tag v1.12.0 created (now 5d65009) |
Wireshark code review |
|
| 18:44 |
[Wireshark-commits] [wireshark] annotated tag wireshark-1.12.0 created (now fb049ef) |
Wireshark code review |
|
| 19:02 |
[Wireshark-commits] master-1.10 6b041ab: Build 1.10.9. |
Wireshark code review |
|
| 19:03 |
[Wireshark-commits] [wireshark] annotated tag v1.10.9 created (now f8ddc5e) |
Wireshark code review |
|
| 19:03 |
[Wireshark-commits] [wireshark] annotated tag wireshark-1.10.9 created (now c99d3c0) |
Wireshark code review |
|
| 19:29 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 20:56 |
[Wireshark-commits] master 43a81b6: Add some information on running from the build directory. |
Wireshark code review |
|
| 20:59 |
[Wireshark-commits] master 9a03227: this is the _URB_ transfer type - which is different from the transfer type in the endpoint descriptor |
Wireshark code review |
|
| 20:59 |
[Wireshark-commits] master f3982ee: defines for endpoint transfer types |
Wireshark code review |
|
| 21:00 |
[Wireshark-commits] master d05e679: sync and behaviour are defined only for isochronous endpoints |
Wireshark code review |
|
| 21:01 |
[Wireshark-commits] master cb96099: Lua - it's not just for breakfast^Wdissectors any more! |
Wireshark code review |
|
| 21:17 |
[Wireshark-commits] master 1ebfb3f: Distinguish between wireshark *source files* and wireshark *dependencies*. |
Wireshark code review |
|
| 21:59 |
[Wireshark-commits] master f38c7d6: Copy over autofoo change: No more .h file. |
Wireshark code review |
|
| 22:35 |
[Wireshark-commits] master-1.12 3d8fb9c: 1.12.0 → 1.12.1. |
Wireshark code review |
|
| 22:36 |
[Wireshark-commits] [wireshark] annotated tag v1.12.0rc0 created (now edd67e6) |
Wireshark code review |
|
| 22:38 |
[Wireshark-commits] master-1.10 4e036bf: 1.10.9 → 1.10.10. |
Wireshark code review |
|
| 22:38 |
[Wireshark-commits] [wireshark] annotated tag v1.10.10rc0 created (now b53157b) |
Wireshark code review |
|
