Wireshark-commits: [Wireshark-commits] master 980893a: NDPS dissector is the poster child for proto
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Jul 2014 17:35:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=980893a15afba3d4ed654734a386009c27c18358
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

980893a by Michael Mann (mmann78@xxxxxxxxxxxx):

    NDPS dissector is the poster child for proto_tree_add_subtree[_format].
    
    NDPS dissector is also the poster child for not being considered "that naughty" by checkAPIs because most of its proto_tree_add_text calls don't have printf-style arguments (which is what checkAPIs really keys off of)
    
    Fixed both cases and removed about 370 proto_tree_add_text calls from the dissector.
    
    Change-Id: I721678c39d4a0544e5e7212e622c0c2eebfd04f7
    Reviewed-on: https://code.wireshark.org/review/2775
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  a3bac6d   kafka: fully dissect offset request/response messages
    adds  980893a   NDPS dissector is the poster child for proto_tree_add_subtree[_format].


Summary of changes:
 epan/dissectors/packet-ndps.c | 1389 +++++++++++++++++------------------------
 1 file changed, 558 insertions(+), 831 deletions(-)