Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 ef90ec1: packet-vnc.c: Improve dissection

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef90ec1a8b34e0f47de61bac7a831e526d511e15
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

ef90ec1 by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-vnc.c: Improve dissection
    
    - Properly dissect multiple VNC PDUs in one (or more) TCP segment(s).
    - Dissect additional message types ('Fence' and 'Enable Continuous Updates').
    - Handle "num_rects" field = 0xFFFF (TightVNC).
    - Add some more info as to sources of information about the VNC protocol.
    - Add an XXX note as to the (incorrect) reassembly method being used.
    - Add some notes as to possible ToDo's.
    
    Backported to master-1.12 from master
    
    Change-Id: Id4942c50b3d1373bd2e72c0131614835dc39ba90
    Reviewed-on: https://code.wireshark.org/review/2834
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/3004
    

Actions performed:

    from  7f36674   remove duplicate offset=0
    adds  ef90ec1   packet-vnc.c: Improve dissection


Summary of changes:
 epan/dissectors/packet-vnc.c |  308 +++++++++++++++++++++++++++++++++++-------
 1 file changed, 260 insertions(+), 48 deletions(-)