Wireshark-commits: [Wireshark-commits] master 9ed85d1: Fix use of uninitialized field
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 Jul 2014 16:25:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ed85d1de980cb92c1a5d14f400dec2ac98eb6d9
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9ed85d1 by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix use of uninitialized field
    
    ssl_print_string uses out->data_len to determine the length of the
    printed data, but this was not set. Use ssl_data_set for that and add an
    additional DISSECTOR_ASSERT just in case we change something here.
    
    Reported by Alexis La Goutte, found by Clang static analyzer.
    
    Change-Id: I630a9193ff1ece86a0a46924dd86591fedf5c595
    Reviewed-on: https://code.wireshark.org/review/3261
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  dcf6d44   Apply refactored "conversation" (tap) data to TShark.
    adds  9ed85d1   Fix use of uninitialized field


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)