Wireshark-commits: [Wireshark-commits] master 5886e45: iscsi: minor retval fix
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Jul 2014 15:51:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5886e45179844c412c67a226010a12039ebbcc0a
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5886e45 by Peter Wu (peter@xxxxxxxxxxxxx):

    iscsi: minor retval fix
    
    The return value of new dissectors is the number of bytes that were
    successfully dissected, not a boolean. Fix that and get rid of an
    unnecessary iSCSIPdusDissected variable.
    
    Change-Id: Ie31df393a1eb44f185d320a4c2d35f5e8b7d7bd9
    Reviewed-on: https://code.wireshark.org/review/2889
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  d828b15   kismet: fix retval, add modelines
    adds  5886e45   iscsi: minor retval fix


Summary of changes:
 epan/dissectors/packet-iscsi.c |  194 ++++++++++++++++++++--------------------
 1 file changed, 96 insertions(+), 98 deletions(-)