Wireshark-commits: [Wireshark-commits] master-1.12 8a47b3a: pre-commit: Add 'unset GREP_OPTIONS' (s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Jul 2014 20:13:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a47b3a78cc61d4ff54c450faacfa80fc09786bf
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

8a47b3a by Bill Meier (wmeier@xxxxxxxxxxx):

    pre-commit: Add 'unset GREP_OPTIONS' (similar to Gerrit commit-msg)
    
      msysgit grep is fairly old and doesn't recognize certain
      grep options, e.g., '--color=auto'.
    
      I imagine there may possibly be other grep option issues
      on various platforms.
    
      (I also note that the various git scripts in libexec/git-core
       clear out GREP_OPTIONS before calling grep).
    
    Change-Id: I67bc148a77cfc0167064e61e8c47a5f091704eac
    Reviewed-on: https://code.wireshark.org/review/2945
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit b66f614e5d5fee0aad1eb025c228fcbf7f2aae7e)
    Reviewed-on: https://code.wireshark.org/review/2948
    

Actions performed:

    from  de09662   tools/pre-commit: Complete all checks on all files before exiting with Ok/Fail status.
    adds  8a47b3a   pre-commit: Add 'unset GREP_OPTIONS' (similar to Gerrit commit-msg)


Summary of changes:
 tools/pre-commit |    2 ++
 1 file changed, 2 insertions(+)