Wireshark-commits: [Wireshark-commits] master afa8f21: make-dissectors-reg: optimize by factoring o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Jul 2014 08:08:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=afa8f21f56f1e65bb2ec37cffdf3422d15b45347
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

afa8f21 by Роман Донченко (dpb@xxxxxxxxxxxxxx):

    make-dissectors-reg: optimize by factoring out the loops
    
    Instead of calling the grep/sed pipelines for each file, build the
    list of files in the beginning and call each pipeline only once,
    passing the list to the first grep.
    
    This results in a massive speedup in Cygwin; in my test, the time
    it takes to run make-dissector-reg . dissectors packet-*.c in dissectors/epan
    is reduced from ~116 to ~3 seconds. I also tried it on NetBSD, where
    the time do to the same goes from ~6 to ~0.5 seconds.
    
    Amend makefile comments to elide mentions of invoking multiple processes
    per file.
    
    Change-Id: Iad441e7d2b6cc3669dada57646e2f8f6b987fd34
    Reviewed-on: https://code.wireshark.org/review/2826
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3490bc6   Change display filters to prefix with ipmi.trace
    adds  afa8f21   make-dissectors-reg: optimize by factoring out the loops


Summary of changes:
 epan/dissectors/Makefile.am        |   10 ++--
 epan/dissectors/Makefile.nmake     |   10 ++--
 plugins/asn1/Makefile.am           |   10 ++--
 plugins/asn1/Makefile.nmake        |   10 ++--
 plugins/docsis/Makefile.am         |   10 ++--
 plugins/docsis/Makefile.nmake      |   10 ++--
 plugins/ethercat/Makefile.am       |   10 ++--
 plugins/ethercat/Makefile.nmake    |   10 ++--
 plugins/gryphon/Makefile.am        |   10 ++--
 plugins/gryphon/Makefile.nmake     |   10 ++--
 plugins/irda/Makefile.am           |   10 ++--
 plugins/irda/Makefile.nmake        |   10 ++--
 plugins/m2m/Makefile.am            |   10 ++--
 plugins/m2m/Makefile.nmake         |   10 ++--
 plugins/mate/Makefile.am           |   10 ++--
 plugins/mate/Makefile.nmake        |   10 ++--
 plugins/opcua/Makefile.am          |   10 ++--
 plugins/opcua/Makefile.nmake       |   10 ++--
 plugins/profinet/Makefile.am       |   10 ++--
 plugins/profinet/Makefile.nmake    |   10 ++--
 plugins/unistim/Makefile.am        |   10 ++--
 plugins/unistim/Makefile.nmake     |   10 ++--
 plugins/wimax/Makefile.am          |   10 ++--
 plugins/wimax/Makefile.nmake       |   10 ++--
 plugins/wimaxasncp/Makefile.am     |   10 ++--
 plugins/wimaxasncp/Makefile.nmake  |   10 ++--
 plugins/wimaxmacphy/Makefile.am    |   10 ++--
 plugins/wimaxmacphy/Makefile.nmake |   10 ++--
 tools/make-dissector-reg           |  116 +++++++++++-------------------------
 29 files changed, 176 insertions(+), 220 deletions(-)