Wireshark-commits: [Wireshark-commits] master ba6d2e7: ssl: move Certificate handshake dissection t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2014 04:35:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba6d2e7cc8d8d06e9b879813d3e11dc7855a9e99
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba6d2e7 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: move Certificate handshake dissection to ssl-utils
    
    There are no dissection differences between DTLS and SSL, so move to
    ssl-utils. While at it, skip dissection when the tree is NULL, remove
    the plural from certificates length (the length is always larger than
    ome), fix type of "ti" for dtls, get rid of "failsafe" subtree
    assignment in ssl, get rid of tvb_ensure_bytes_exist in ssl.
    
    Unrelated changes: fix param (tvb vs sub_tvb) for DTLS KeyExchange
    handshake messages.
    
    Change-Id: Iecaa45a7a601e55a52aa16180cf219a122fbe95a
    Reviewed-on: https://code.wireshark.org/review/2985
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  7248c24   ssl: add missing valid handshake types
    adds  ba6d2e7   ssl: move Certificate handshake dissection to ssl-utils


Summary of changes:
 epan/dissectors/packet-dtls.c      |   95 +--------------------------------
 epan/dissectors/packet-ssl-utils.c |   61 +++++++++++++++++++++
 epan/dissectors/packet-ssl-utils.h |   37 +++++++++++--
 epan/dissectors/packet-ssl.c       |  103 ++----------------------------------
 4 files changed, 100 insertions(+), 196 deletions(-)