Wireshark · Wireshark-commits: [Wireshark-commits] master-1.10 eed3850: Don't return an error string for NO_INTERFACES_FOUND.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eed38500352180eab1b14102a1ec60b2b47745f6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

eed3850 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't return an error string for NO_INTERFACES_FOUND.
    
    Most callers of capture_interface_list() don't expect an error string
    for NO_INTERFACES_FOUND, because that's not really an error, it's just a
    statement of face (and perhaps an error of 0 should be returned), so
    they don't bother freeing the error string, causing a leak.
    
    Instead, have the one place that *did* expect it to return an error
    string just put "No interfaces found" itself.
    
    Also, have that place not check for an error string if interfaces *were*
    found, as no error code or string is returned in that case.
    
    Change-Id: I95018d647bf2bcea6732bdf4ffb48615ba669b2c
    Reviewed-on: https://code.wireshark.org/review/3168
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  490cf7c   [Automatic manuf, services and enterprise-numbers update for 2014-07-20]
    adds  eed3850   Don't return an error string for NO_INTERFACES_FOUND.


Summary of changes:
 capture_ifinfo.c         |    5 +----
 ui/qt/interface_tree.cpp |   10 ++++++----
 2 files changed, 7 insertions(+), 8 deletions(-)