Wireshark · Wireshark-commits: [Wireshark-commits] master a6fc598: Enhance HTTP/2 HPACK header decompression handling

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6fc598aa79f45f0ece6c17656b15e323815cccf
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a6fc598 by Tatsuhiro Tsujikawa (tatsuhiro.t@xxxxxxxxx):

    Enhance HTTP/2 HPACK header decompression handling
    
    Previously we just call HPACK decompressor when dessecting packets.
    This is fine for the first linear scan.  But later same packet may be
    dissected more than once and their header block data will be fed into
    decompressor again.  This makes header compression context out-of-sync
    because HPACK decompressor only works when data is fed linearly.  This
    change fixes this issue by caching decompressed headers in the first
    linear scan.  On random packet dissecting, they are just looked up.
    This change adds support of changing header table size by inspecting
    SETTINGS frame and tracking its SETTINGS ACK.
    
    Change-Id: I9c75c67f8677063e443f9b131740f3ee94ff8a63
    Reviewed-on: https://code.wireshark.org/review/2616
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  36c3933   Dissect HTTP/2 draft-13
    adds  a6fc598   Enhance HTTP/2 HPACK header decompression handling


Summary of changes:
 epan/dissectors/packet-http2.c |  366 ++++++++++++++++++++++++++++------------
 1 file changed, 255 insertions(+), 111 deletions(-)