Wireshark-commits: [Wireshark-commits] master-1.12 0da9639: Don't return an error string for NO_INT
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Jul 2014 20:41:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0da9639dad31519b84a26f0a858a0bfede4b39cf
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

0da9639 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't return an error string for NO_INTERFACES_FOUND.
    
    Most callers of capture_interface_list() don't expect an error string
    for NO_INTERFACES_FOUND, because that's not really an error, it's just a
    statement of face (and perhaps an error of 0 should be returned), so
    they don't bother freeing the error string, causing a leak.
    
    Instead, have the one place that *did* expect it to return an error
    string just put "No interfaces found" itself.
    
    Also, have that place not check for an error string if interfaces *were*
    found, as no error code or string is returned in that case.
    
    Change-Id: I9cb8ed7ad22810b23e2251d2833d9b7ab02eec03
    Reviewed-on: https://code.wireshark.org/review/3165
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/3167
    

Actions performed:

    from  d11b733   1.12.0rc3 → 1.12.0rc4
    adds  0da9639   Don't return an error string for NO_INTERFACES_FOUND.


Summary of changes:
 capture_ifinfo.c         |    5 +----
 ui/qt/interface_tree.cpp |   10 +++++++---
 2 files changed, 8 insertions(+), 7 deletions(-)