Wireshark-commits: [Wireshark-commits] master 4261109: Don't return an error string for NO_INTERFAC
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4261109e1e15ec16b3d38df9e6011d676a558487
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
4261109 by Guy Harris (guy@xxxxxxxxxxxx):
Don't return an error string for NO_INTERFACES_FOUND.
Most callers of capture_interface_list() don't expect an error string
for NO_INTERFACES_FOUND, because that's not really an error, it's just a
statement of face (and perhaps an error of 0 should be returned), so
they don't bother freeing the error string, causing a leak.
Instead, have the one place that *did* expect it to return an error
string just put "No interfaces found" itself.
Also, have that place not check for an error string if interfaces *were*
found, as no error code or string is returned in that case.
Change-Id: I9cb8ed7ad22810b23e2251d2833d9b7ab02eec03
Reviewed-on: https://code.wireshark.org/review/3165
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 7bc24ed Add back a 'dummy' comment I removed with commit e91121e1435d97c92
adds 4261109 Don't return an error string for NO_INTERFACES_FOUND.
Summary of changes:
capchild/capture_ifinfo.c | 5 +----
ui/qt/interface_tree.cpp | 10 +++++++---
2 files changed, 8 insertions(+), 7 deletions(-)
