Wireshark · Wireshark-commits: [Wireshark-commits] master aecbb98: ssl: unify common Hello dissection to ssl-utils

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aecbb98365e3391603c203de4d2d1a6685f7247d
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

aecbb98 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: unify common Hello dissection to ssl-utils
    
    Based on DTLS code with changes merged from SSL. Changes:
    
     - Ignore large Session IDs, this was not harmful though since the
       backing storage was 256 bytes in size.
     - {ssl,dtls}.handshake.random: fixed description, it is not used like
       a SSLv2 random challenge.
     - dtls: also debug print client/server for random
     - SSL: the common dissector now returns an offset rather than dissected
       length.
     - dtls: display actual Session ID bytes in the UI rather than the text
       "Session ID (32 bytes)". The length field is already visible in the
       preceding field.
    
    Also changed is the handling of key material generation. The SSL
    dissector previously generated key material based on the Session ID,
    Session Ticket or a key logfile. (DTLS did not have this functionality.)
    As decryption is needed only after ChangeCipherSpec, I have removed it
    from the ServerHello handling. This will break decryption when a
    ClientKeyExchange message is missing, but it will be restored proper in
    a next patch.
    
    (By the way, there was an inverted if-condition bug in DTLS that could
    break decryption by not restoring the master key matching a SID. This
    is gone in the refactoring because the faulty code is removed.)
    
    Change-Id: Ida3de88adefe3f7691f85936c496977426c4d96e
    Reviewed-on: https://code.wireshark.org/review/3018
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  8982e87   Looks like this file is completely outdated - at least the problems it mentions are.
    adds  aecbb98   ssl: unify common Hello dissection to ssl-utils


Summary of changes:
 epan/dissectors/packet-dtls.c      |  107 +------------------------------
 epan/dissectors/packet-ssl-utils.c |   68 ++++++++++++++++++++
 epan/dissectors/packet-ssl-utils.h |   33 ++++++++++
 epan/dissectors/packet-ssl.c       |  121 +-----------------------------------
 4 files changed, 106 insertions(+), 223 deletions(-)