Wireshark · Wireshark-commits: [Wireshark-commits] master 286c191: 9p: fix version detection, fix dissect_9P retval

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=286c191846c4fff65e9855363521a6975b8c5a19
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

286c191 by Peter Wu (peter@xxxxxxxxxxxxx):

    9p: fix version detection, fix dissect_9P retval
    
    Fix version detection (detect against full string instead of prefix),
    properly dissect Tcreate extension field (9p2000.u only), dissect
    Tunlinkat flags (9p2000.L).
    
    Refactor pattern to dissect string[s] types for DRY.
    
    Convert to use tcp_dissect_pdus. I have not seen a fragmented case, but
    maybe that may happen in the future.
    
    The main motivation for touching 9p was that it returns bogus values
    for some types. This has been fixed by properly increasing offset, and
    always return the captured length.
    
    Change-Id: If2184204ae9c853b94aca8ade3763d7fe523fa86
    Reviewed-on: https://code.wireshark.org/review/2836
    Reviewed-by: Christopher Maynard <Christopher.Maynard@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  fc63343   convert to proto_tree_add_subtree[_format]
    adds  286c191   9p: fix version detection, fix dissect_9P retval


Summary of changes:
 epan/dissectors/packet-9p.c |  281 ++++++++++++++++---------------------------
 1 file changed, 105 insertions(+), 176 deletions(-)