Wireshark-commits: [Wireshark-commits] master 2eae8bb: mikey: do not request more data on proto vio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Jul 2014 15:45:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2eae8bb0c332302f2b63839efb9ea628dfea1127
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2eae8bb by Peter Wu (peter@xxxxxxxxxxxxx):

    mikey: do not request more data on proto violation
    
    Return value "-1" means that more data is requested. The dissector
    actually doesn't have any idea what to do with the data, so just return
    the data dissected so far.
    
    tcp stream 3182 from c05-http-reply-r1.pcap (SampleCaptures) was
    incorrectly detected as MIKEY, it was actually HTTP...
    
    Change-Id: Idca3d3e2f85e821df70436a675699b5834236f89
    Reviewed-on: https://code.wireshark.org/review/2887
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  b54731d   ms-mms: fix retval for short pkts, fix reading flags
    adds  2eae8bb   mikey: do not request more data on proto violation


Summary of changes:
 epan/dissectors/packet-mikey.c |   38 ++++++++++++++++++++++++++------------
 1 file changed, 26 insertions(+), 12 deletions(-)