Wireshark · Wireshark-commits: [Wireshark-commits] master f724cae: Only ABI-check strncasecmp.h if strncasecmp() is part of the API

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f724cae763a9090000980340525bfc8c855a15b5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f724cae by Guy Harris (guy@xxxxxxxxxxxx):

    Only ABI-check strncasecmp.h if strncasecmp() is part of the API/ABI.
    
    Some routines Wireshark uses are present in some, but not all,
    platforms; for routines that would be used on all platforms, libwsutil
    provides its own implementations on platforms that lack them.
    
    On platforms that provide a routine, that routine will not be part of
    the API and ABI, and, if we do an API or ABI check using the header
    libwsutil provides to declare the function on platforms that lack it, we
    may have a collision between the declaration in our header and the
    declaration in a system header.
    
    There's no guarantee that we can make them match, as the declaration
    might differ from platform to platform and from platform version to
    platform version, so we simply leave the header file out of the check if
    we have the function on the platform on which we're checking the API or
    ABI.
    
    Change-Id: I8a23e63d9e17e5c1f5a83304dbe14d1e7df22e7e
    Reviewed-on: https://code.wireshark.org/review/3115
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  bf514a5   Add casts to squelch compiler warnings.
    adds  f724cae   Only ABI-check strncasecmp.h if strncasecmp() is part of the API/ABI.


Summary of changes:
 configure.ac           |    7 ++++++-
 wsutil/Makefile.am     |   11 ++++++++++-
 wsutil/Makefile.common |   10 ++++++++--
 3 files changed, 24 insertions(+), 4 deletions(-)