Wireshark-commits: [Wireshark-commits] master f229aed: Our users are not particpants in a comedy sk
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Jul 2014 00:43:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f229aeddd2f36e8b136f344b68ac43bdde7506d2
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f229aed by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Our users are not particpants in a comedy sketch.
    
    In way too many places in the GTK+ code we wait for the user to do
    something wrong, leap out from behind the bushes, yell "AHA!", and hit
    them in the face with a herring^W error dialog.
    
    We really need to not do that. We also shouldn't carry that behavior
    over to the Qt UI.
    
    If the user shouldn't press a button it should be disabled. Do so for
    the "Compile BPF" and "Start" buttons.
    
    Change-Id: Iad9c15951d5ae640ea82ca74d5f0c26e88bd2554
    Reviewed-on: https://code.wireshark.org/review/3156
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  fdff1b3   Don't connect to non-existent slots.
    adds  f229aed   Our users are not particpants in a comedy sketch.


Summary of changes:
 ui/qt/capture_filter_combo.cpp      |    2 +-
 ui/qt/capture_interfaces_dialog.cpp |   32 ++++++++++++++++++++++----------
 ui/qt/capture_interfaces_dialog.h   |    1 +
 3 files changed, 24 insertions(+), 11 deletions(-)