Wireshark-commits: [Wireshark-commits] master 4cdd17a: Qt: Cache packet list column strings.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 7 Jul 2014 06:24:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4cdd17a59dca0c9d2597d7974846e2b8ad9e1462
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4cdd17a by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Cache packet list column strings.
    
    For each displayed packet list row, save a copy of or a pointer to
    column strings similar to ui/gtk/packet_list_store.c. This lets us call
    epan_dissect_run only once per row.
    
    Bug: 9511
    Change-Id: I17e8ebeb5ed70518c9047413c3b2a46f01e904ef
    Reviewed-on: https://code.wireshark.org/review/2752
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5938782   Don't cast away constness if not necessary.
    adds  4cdd17a   Qt: Cache packet list column strings.


Summary of changes:
 epan/CMakeLists.txt               |    1 +
 ui/qt/packet_list_model.cpp       |  120 +++------------------
 ui/qt/packet_list_record.cpp      |  216 +++++++++++++++++++++++++++++++++++--
 ui/qt/packet_list_record.h        |   21 ++--
 ui/qt/related_packet_delegate.cpp |    2 +-
 5 files changed, 238 insertions(+), 122 deletions(-)