Wireshark-commits: [Wireshark-commits] master 5e3b044: ssl, dtls: move Session Ticket to ssl-utils
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Jul 2014 20:50:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e3b04449a418d69aa79bdd20a7ba491121c700b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5e3b044 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl,dtls: move Session Ticket to ssl-utils
    
    Changes:
    
     - dtls: also support saving session tickets.
     - Drop the length check and let proto_tree_add_item throw exceptions
       on length errors.
     - Use proto_tree_add_item instead of proto_tree_add_uint.
     - Drop "TLS" from header field descriptions, the RFC does not name it
       as such and DTLS can also use it (a draft is in progress that extends
       DTLS with Session Tickets,
       draft-hummen-dtls-extended-session-resumption-01).
    
    Change-Id: I11195217368b7200821d11289b1c5870a1ffe637
    Reviewed-on: https://code.wireshark.org/review/3029
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  90e46f4   Fix (-W)documentation error found by Clang
    adds  5e3b044   ssl,dtls: move Session Ticket to ssl-utils


Summary of changes:
 epan/dissectors/packet-dtls.c      |   55 ++--------------------------
 epan/dissectors/packet-ssl-utils.c |   37 +++++++++++++++++++
 epan/dissectors/packet-ssl-utils.h |   31 ++++++++++++++--
 epan/dissectors/packet-ssl.c       |   69 ++----------------------------------
 4 files changed, 72 insertions(+), 120 deletions(-)