Wireshark-commits: [Wireshark-commits] master 3a9f126: config.nmake: Do some minor changes (mostly
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Jul 2014 17:39:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3a9f12691744938e11b9e9f6f628164048697c19
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3a9f126 by Bill Meier (wmeier@xxxxxxxxxxx):

    config.nmake: Do some minor changes (mostly in comments).
    
    - Update comment: /O2 enables /Gs which is "Control Stack Checking Calls" not "Buffer Security Check"
    - Remove explicit setting of /GS (Buffer Security Check) since it's set by default.
      (The explicit setting did not apply to the CFLAGS used to compile Wireshark
       files because the setting was in the wrong place, but, fortunately, /GS is on
       by default.
    - Add a comment about /GS being on by default.
    - Remove some trailing whitespace.
    
    Change-Id: I6cf631ee1ba0fb8556171861c7e5eb6d959c8f0c
    Reviewed-on: https://code.wireshark.org/review/3228
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ff01321   Sort diameter.applicationId fix a typo.
    adds  3a9f126   config.nmake: Do some minor changes (mostly in comments).


Summary of changes:
 config.nmake |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)