Wireshark-commits: [Wireshark-commits] master a91dbf7: proto_add_subtree_format(): initialize tree_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 Jul 2014 14:39:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a91dbf7aa7f56f81260dc4b79a67223566e8c258
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a91dbf7 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    proto_add_subtree_format(): initialize tree_item to 'tree' rather than NULL.
    
    ... As would be the case if proto_tree_add_text() + proto_item_add_subtree()
    were used.  (This initialization value is only used when TRY_TO_FAKE_THIS_ITEM()
    shortcuts us out.)
    
    As reported/discussed on -dev:
    
    https://www.wireshark.org/lists/wireshark-dev/201407/msg00031.html
    
    Change-Id: I4af63e3cf0a70607d58b4641597b2ce7907fbb8b
    Reviewed-on: https://code.wireshark.org/review/3271
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  3762440   cmake also needs to learn to build SVR4 packages.
    adds  a91dbf7   proto_add_subtree_format(): initialize tree_item to 'tree' rather than NULL.


Summary of changes:
 epan/proto.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)