Wireshark-commits: [Wireshark-commits] master 9d5bf53: udvm: free the buffer *before* throwing the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Jul 2014 04:21:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9d5bf53346d3ac8b9d3c37726928b41dc50400e0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9d5bf53 by Evan Huus (eapache@xxxxxxxxx):

    udvm: free the buffer *before* throwing the exception
    
    Freeing it after the exception doesn't do much, for obvious reasons. Also move
    the allocation a bit later, and add modelines.
    
    This fixes one major memory leak, although on inspection this code still isn't
    safe since there are exception-throwing functions called all over the place with
    glib memory active. Outside the scope of this fix though.
    
    Bug: 10265
    Change-Id: I1fe272e92b92cac6b99abb84866b8ae9b582e24c
    Reviewed-on: https://code.wireshark.org/review/2931
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8fbc0db   conversion: do not free conversation memory on updates
    adds  9d5bf53   udvm: free the buffer *before* throwing the exception


Summary of changes:
 epan/sigcomp-udvm.c |   19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)