Wireshark-commits: [Wireshark-commits] master 4800894: Cleanup the "export PDU" common code.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2014 20:16:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=480089435746411ac973cc2d3146be6f7317ec5f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4800894 by Guy Harris (guy@xxxxxxxxxxxx):

    Cleanup the "export PDU" common code.
    
    exp_pdu_file_open() isn't used outside ui/tap_export_pdu.c; make it
    static.
    
    do_export_pdu() isn't a tap routine, it's called *from* tap routines, so
    its last argument doesn't need to be a generic pointer; its last
    argument must be a pointer to an exp_pdu_t, so declare it as such.
    
    Clean up comments while we're at it.
    
    Change-Id: Iab51b54a0c272052d7876110a095f2fff66fa2c1
    Reviewed-on: https://code.wireshark.org/review/3060
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  52a4f3d   Add application/atom+xml as an XML document type.
    adds  4800894   Cleanup the "export PDU" common code.


Summary of changes:
 ui/gtk/export_pdu_dlg.c     |    2 +-
 ui/qt/export_pdu_dialog.cpp |    1 +
 ui/tap_export_pdu.c         |    7 +++----
 ui/tap_export_pdu.h         |    5 ++---
 4 files changed, 7 insertions(+), 8 deletions(-)