Wireshark-commits: [Wireshark-commits] master ee231c5: ssl, dtls: move ClientHello to ssl-utils
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee231c526373b1c2e8c750fec0fc42befbfe3a97
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
ee231c5 by Peter Wu (peter@xxxxxxxxxxxxx):
ssl,dtls: move ClientHello to ssl-utils
Changes to ClientHello dissection:
- Move ssl_find_private_key (and its pre-req, ssl_set_server) outside
ssl_dissect_hnd_cli_hello. It has not really something to do with
dissection, but state tracking and decoder param feeding.
- dtls: add expert info for bad cipher suites len.
- ssl: remove bad cipher suites len text label which is also
available as expert info. Attach expert info to a the length proto
item (which is converted to use add_item instead of add_uint).
- Remove `if (tree || ssl)` since expert info seems not to apply
otherwise (this also needs changes in common and handshake
dissection).
- ssl: remove tvb_ensure_bytes_exist so we can dissect more
compression methods and cipher suites.
- Since DTLS has an additional Cookie field which TLS does not have,
pass these additional header fields through a struct whose type is
defined in ssl-utils.
Change-Id: I41bef04c1c3353e582e30f561d1d246a744e1d60
Reviewed-on: https://code.wireshark.org/review/3021
Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
Actions performed:
from aa09fea ssl,dtls: move ServerHello to ssl-utils
adds ee231c5 ssl,dtls: move ClientHello to ssl-utils
Summary of changes:
epan/dissectors/packet-dtls.c | 201 +++---------------------------------
epan/dissectors/packet-ssl-utils.c | 118 +++++++++++++++++++++
epan/dissectors/packet-ssl-utils.h | 60 ++++++++++-
epan/dissectors/packet-ssl.c | 191 +++-------------------------------
4 files changed, 205 insertions(+), 365 deletions(-)
