Wireshark-commits: [Wireshark-commits] master df6bdcc: packet-vnc.c: Improve dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Jul 2014 21:51:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df6bdcc07d4b2dc7877007cfa04830761acb0d0f
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

df6bdcc by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-vnc.c: Improve dissection
    
    - Properly dissect multiple VNC PDUs in one (or more) TCP segment(s).
    - Dissect additional message types ('Fence' and 'Enable Continuous Updates').
    - Handle "num_rects" field = 0xFFFF (TightVNC).
    - Add some more info as to sources of information about the VNC protocol.
    - Add an XXX note as to the (incorrect) reassembly method being used.
    - Add some notes as to possible ToDo's.
    
    Change-Id: Id4942c50b3d1373bd2e72c0131614835dc39ba90
    Reviewed-on: https://code.wireshark.org/review/2834
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  60a6f85   Manually revert "Make COMPUTE_OFFSET and COMPUTE_OFFSET_AND_REMAINING macros."
    adds  df6bdcc   packet-vnc.c: Improve dissection


Summary of changes:
 epan/dissectors/packet-vnc.c |  320 +++++++++++++++++++++++++++++++++++-------
 1 file changed, 266 insertions(+), 54 deletions(-)