Wireshark-commits: [Wireshark-commits] master 9335faa: Moved USB Setup Response Dissection into own
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2014 22:54:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9335faa6a2a3daeb6a096e442a9fbb2186fafd13
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9335faa by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    Moved USB Setup Response Dissection into own function
    
    USB Setup Responses are now dissected in their own function.
    Before they were dissected inline in the usb_dissect_common()
    function.
    (just copied code).
    
    Also replaced proto_tree_add_text() with proto_tree_add_item()
    for generic setup response data.
    
    Change-Id: Ia3943334cccc0a1813e0c906196307f99561ad21
    Reviewed-on: https://code.wireshark.org/review/2959
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  b33f777   Fix Dereference of null pointer found by Clang analyzer
    adds  9335faa   Moved USB Setup Response Dissection into own function


Summary of changes:
 epan/dissectors/packet-usb.c |  113 +++++++++++++++++++++++++++---------------
 1 file changed, 73 insertions(+), 40 deletions(-)