Wireshark-commits: [Wireshark-commits] master-1.12 21bf67a: Have buffer_free() null out the buffer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2014 23:23:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21bf67a98db6474956d2e67e0532108a4c7980c2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

21bf67a by Guy Harris (guy@xxxxxxxxxxxx):

    Have buffer_free() null out the buffer data pointer.
    
    That prevents some double-free issues (I got one when doing non-"Update
    list of packets in real time" captures, if I do one such capture and
    then another one).
    
    Change-Id: Ia08034d9d1640bad21b74960efade8926dbfc5de
    Reviewed-on: https://code.wireshark.org/review/3063
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 7344cfc78ff89603af6dec685ed968f5954e757d)
    Reviewed-on: https://code.wireshark.org/review/3064
    

Actions performed:

    from  15b43a1   HTTP2: Fix double free
    adds  21bf67a   Have buffer_free() null out the buffer data pointer.


Summary of changes:
 filetap/buffer.c |    3 ++-
 wiretap/buffer.c |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)