Wireshark-commits: [Wireshark-commits] master 0492921: Replace lseek/fstat by ws_lseek64/ws_fstat64
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 25 Jul 2014 21:26:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0492921adc1d6e3978b93bcac35140510228a62a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0492921 by Peter Wu (peter@xxxxxxxxxxxxx):

    Replace lseek/fstat by ws_lseek64/ws_fstat64
    
    lseek returns an off_t type which is system-dependent. Use ws_lseek64 in
    favor of lseek as that supports 64-bit quanities.
    
    Use ws_fstat64 instead of stat to support 64-bit file sizes on Windows.
    For the majority of the changes, this makes no difference as they do not
    apply to Windows ("ifndef _WIN32"; availability of st_blksize).
    
    There are no other users of "struct stat" besides the portability code
    in wsutil. Forbid the use of fstat and lseek in checkAPIs.
    
    Change-Id: I17b930ab9543f21a9d3100f3795d250c9b9ae459
    Reviewed-on: https://code.wireshark.org/review/3198
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c3e42cc   OptoMMP Dissector
    adds  0492921   Replace lseek/fstat by ws_lseek64/ws_fstat64


Summary of changes:
 filetap/ft_file_wrappers.c |    4 ++--
 plugins/asn1/packet-asn1.c |    4 ++--
 tfshark.c                  |    4 ++--
 tools/checkAPIs.pl         |    2 ++
 tshark.c                   |    4 ++--
 wiretap/file_access.c      |    4 ++--
 wiretap/file_wrappers.c    |    4 ++--
 7 files changed, 14 insertions(+), 12 deletions(-)