Wireshark-bugs: [Wireshark-bugs] [Bug 4152] New dissector for LTP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 27 Oct 2009 13:36:28 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4152


Mithun Roy <mithunroy13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #3825 is|0                           |1
           obsolete|                            |
   Attachment #3849|                            |review_for_checkin?
               Flag|                            |




--- Comment #4 from Mithun Roy <mithunroy13@xxxxxxxxx>  2009-10-27 13:36:26 PDT ---
Created an attachment (id=3849)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=3849)
Ltp dissector, with suggested changes

The following suggested changes have been made from the previous patch.


- Use of hf_ entries and use of proto_tree_add_*() to add elements to the tree,
instead of proto_tree_add_text().

- Use of value_string and val_to_str() to avoid big switch statements.

- Removed the C++ style comments.


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.