Wireshark-bugs: [Wireshark-bugs] [Bug 4152] New dissector for LTP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 24 Oct 2009 09:19:00 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4152


Stig Bjørlykke <stig@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3825|review_for_checkin?         |review_for_checkin-
               Flag|                            |




--- Comment #3 from Stig Bjørlykke <stig@xxxxxxxxxxxxx>  2009-10-24 09:18:55 PDT ---
(From update of attachment 3825)
- Please use hf_ entries and proto_tree_add_item() to add elements to the tree.
 The function proto_tree_add_text() should not be used.

- Use value_string tables and val_to_str() to handle ltp_type.  The big switch
should be rewritten.

- Don't use C++ comments


-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.