Wireshark-dev: Re: [Wireshark-dev] Question regarding emem -> wmem conversion
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 13 Sep 2013 11:33:29 +0200
On Thu, Sep 12, 2013 at 12:38:37PM -0400, Evan Huus wrote:
> Unfortunately emem.h is included everywhere via packet.h via
> packet_info.h via address.h, so there are dissectors that use it
> without including it directly. check-APIs is more reliable since it
> actually looks for the function calls.

I've tried to clean up the emem.h includes a bit and think I am finished
except for epan/dissectors/. The reason is that the DISSECTOR_ASSERT...
macros contain ep_macros, so I'd have to include emem.h in every dissector
that calls DISSECTOR_ASSERT..., which doesn't look like a nice option but
that's the problem with macros vs. functions.

Ciao
      Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.