Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 51972: /trunk/epan/dissectors/ /trun
The changes to packet-tpncp.c are unfortunately not valid (thus the
recent buildbot test failures). The old code called ep_alloc when no
packet was in scope in the init function, which emem shouldn't have
been allowing in the first place.
This is one of the non-trivial cases you referred to - it should
*probably* be replaced with manually-managed memory (passing a NULL
allocator to wmem), which involves figuring out where and when all the
appropriate free calls should occur.
I've gotten in the habit of just running ./tshark -v before I commit a
batch of conversions, since it's very hard to notice these cases
otherwise.
On Thu, Sep 12, 2013 at 12:15 PM, <jmayer@xxxxxxxxxxxxx> wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51972
>
> User: jmayer
> Date: 2013/09/12 09:15 AM
>
> Log:
> emem -> wmem
>
> Directory: /trunk/epan/dissectors/
> Changes Path Action
> +6 -6 packet-tds.c Modified
> +12 -12 packet-telnet.c Modified
> +2 -2 packet-tipc.c Modified
> +11 -11 packet-tpncp.c Modified
> +4 -4 packet-tr.c Modified
>
> ___________________________________________________________________________
> Sent via: Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
> mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe
