Wireshark-dev: Re: [Wireshark-dev] Question regarding emem -> wmem conversion
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 13 Sep 2013 11:25:50 +0200
On Fri, Sep 13, 2013 at 10:39:08AM +0200, Dario Lombardo wrote:
> Thanks for your description.
> 
> On Thu, Sep 12, 2013 at 11:46 PM, Joerg Mayer <jmayer@xxxxxxxxx> wrote:
> 
> > Here is what I do (now) - I'm on Linux:
> > - cd epan/dissectors/
> > - Pick a letter from the alphabet.
> > - grep emem.h packet-<letter>*.c
> > - ../../tools/checkAPI.pl -g emem packet-<letter>*.c
> >
> 
> ../../tools/checkAPIs.pl -g emem packet-cdp.c
> packet-cdp.c: found 69 useless add_text() vs. 76 add_<something else>()
> calls (90.79%)
> 
> What should be done for that? Is that related to emem?

No, I just couldn't find an option to turn off the default checks, so we
get them as well. The emem hits all look like this:
Warning: Found emem APIs in proto.h: ep_strdup_printf
Warning: Found emem APIs in proto.h: ep_strdup_printf

Ciao
   Jörg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.