Wireshark-commits: [Wireshark-commits] master eb4e2cc: IO Graph does no return to 0 if there are no
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Jan 2020 10:04:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=eb4e2cca69c5057995ff7d59848d784895904bb0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

eb4e2cc by Alexander Meier (MeierAPunkt@xxxxxxxxxxxxxx):

    IO Graph does no return to 0 if there are no fields for y
    
    IO Graph used to show a value of 0 if there are no relevant
    fields/packets when using SUM, MAX, MIN or LOAD. This is an
    issue because you can not distinguish if there was a value
    of 0 or if there was not even a relevant field/packet. With
    this patch IO Graph shows no point in the interval if there
    is no relevant field/packet when using SUM, MAX, MIN or LOAD.
    
    Change-Id: I9b17447cb38efe6dbf9299ec67aac999cfa744a3
    Reviewed-on: https://code.wireshark.org/review/35859
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0290bd3   HTTP: share dissector status value_string array with tshark HTTP stats
     add  eb4e2cc   IO Graph does no return to 0 if there are no fields for y


Summary of changes:
 ui/qt/io_graph_dialog.cpp | 63 ++++++++++++++++++++++++++++++++++++-----------
 ui/qt/io_graph_dialog.h   |  1 +
 2 files changed, 50 insertions(+), 14 deletions(-)