Wireshark-commits: [Wireshark-commits] master 97f90c0: androiddump: Link against libwiretap and lib
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Jan 2020 10:05:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97f90c07ac9a3867233c9b891060d1bd621f5833
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

97f90c0 by Jeroen Roovers (jer@xxxxxxxxxx):

    androiddump: Link against libwiretap and libwsutil
    
    With BUILD_androiddump and EXTCAP_ANDROIDDUMP_LIBPCAP enabled, the
    linker notices a couple of cases of underlinking:
    
    extcap/androiddump.c:541: error: undefined reference to 'ws_inet_pton4'
    extcap/androiddump.c:685: error: undefined reference to 'ws_hexstrtou32'
    extcap/androiddump.c:2513: error: undefined reference to 'cmdarg_err_init'
    extcap/androiddump.c:2517: error: undefined reference to 'data_file_url'
    extcap/androiddump.c:2629: error: undefined reference to 'ws_strtou16'
    extcap/androiddump.c:2592: error: undefined reference to 'ws_strtou16'
    extcap/androiddump.c:2646: error: undefined reference to 'ws_strtou16'
    extcap/androiddump.c:1708: error: undefined reference to 'ws_inet_pton4'
    extcap/androiddump.c:1783: error: undefined reference to 'ws_inet_pton4'
    
    Fix that by explicitly linking against libwiretap and libwsutil when the
    linker cannot find those symbols by linking to them through libwireshark.
    
    Change-Id: I4db266fe82927c12d18fec06f9d766b9390bcec3
    Reviewed-on: https://code.wireshark.org/review/35855
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  eb4e2cc   IO Graph does no return to 0 if there are no fields for y
     add  97f90c0   androiddump: Link against libwiretap and libwsutil


Summary of changes:
 extcap/CMakeLists.txt | 3 +++
 1 file changed, 3 insertions(+)