Wireshark-commits: [Wireshark-commits] master-3.2 aa3be87: Bugfix SMB IOCTL response with BUFFER_OV
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Jan 2020 10:04:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa3be879c4b67abad8af1f3166d5b1b68f19458a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

aa3be87 by Volodymyr Khomenko (volodymyr@xxxxxxxxxxxx):

    Bugfix SMB IOCTL response with BUFFER_OVERFLOW
    
    In case if SMB IOCTL response packet (seen to happen for FSCTL_PIPE_TRANSCEIVE but applicable for others)
    has STATUS_BUFFER_OVERFLOW status code, dissection is done improperly
    (wrong offset to IOCTL response body is calculated so content is corrupted).
    Packet body with STATUS_BUFFER_OVERFLOW status should be handled in the same way as STATUS_SUCCESS packet.
    
    Bug: 16261
    Change-Id: I05d05ed9fa16f8b128590cd505fe9b0270dd74ab
    Reviewed-on: https://code.wireshark.org/review/35341
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 718837ac45ef3b74d6e1444ec36055ff55443767)
    Reviewed-on: https://code.wireshark.org/review/35941
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  a8d3c1b   IPv4: Fix display of Fragment Offset field
     add  aa3be87   Bugfix SMB IOCTL response with BUFFER_OVERFLOW


Summary of changes:
 epan/dissectors/packet-smb2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)