Wireshark-commits: [Wireshark-commits] master-3.2 750b1fa: Revert "Qt: Fix dangling delete for sequ
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 08 Jan 2020 15:30:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=750b1faeca22fa345d09553152278b3df30ded06
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

750b1fa by Jim Young (jyoung@xxxxxxx):

    Revert "Qt: Fix dangling delete for sequence diagramm"
    
    This reverts commit aa2145982f3aec7320f33d201a17d0fdbea2a6c0.
    
    Each of the three delete calls added to the deconstructor
    SequenceDialog::~SequenceDialog() results in Wireshark
    crashing when the Flow dialog is closed.
    
    Bug: 16260
    Change-Id: Iecbd5dcc16be6eb451b8920b22ca2b9ccef7c7b0
    Reviewed-on: https://code.wireshark.org/review/35521
    Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    (cherry picked from commit 31570163d14da6de4a1b7fde4fdde2ff9b9d20a9)
    Reviewed-on: https://code.wireshark.org/review/35696
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  ada7679   Docs: Ensure that the API reference has the proper permissions.
     add  750b1fa   Revert "Qt: Fix dangling delete for sequence diagramm"


Summary of changes:
 ui/qt/sequence_dialog.cpp | 3 ---
 1 file changed, 3 deletions(-)