Wireshark-commits: [Wireshark-commits] master b553066: Netlink: remove encoding copies and, by exte
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b553066a331f7f45447962f5cc32161db44308ea
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
b553066 by Jaap Keuter (jaap.keuter@xxxxxxxxx):
Netlink: remove encoding copies and, by extension, nl_data copies
The underlying netlink dissector sets up a data structure to help maintain
information about the netlink packet. This contains the encoding information
as determined for this packet. Use this value in place of the copy that
every netlink dissector makes in its private data structure.
As a consequence the encoding field can be removed from these private data
structures. Since the encoding field is now directly available from the
data structure setup by the underlying netlink dissector, the private data
structures also do not need to keep a pointer to this underlying netlink
dissector data structure.
This change replaces the use of the local copy of encoding with the
original one. This change, by extension, also removes the encoding field and
the pointer to the underlying netlink dissector data structure as these are
no longer needed. The exception is the generic netlink dissector, which
implements the dynamic netlink famiily subdissector table.
Change-Id: Ida0065379c19ae68caf6d87860828b48766c1998
Reviewed-on: https://code.wireshark.org/review/35698
Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 3b781db rtp_player_dialog: Route audio for a stream to left/right speaker in RTP player
add b553066 Netlink: remove encoding copies and, by extension, nl_data copies
Summary of changes:
epan/dissectors/packet-netlink-generic.c | 30 ++++-----
epan/dissectors/packet-netlink-net_dm.c | 48 ++++++--------
epan/dissectors/packet-netlink-netfilter.c | 17 ++---
epan/dissectors/packet-netlink-nl80211.c | 24 +++----
epan/dissectors/packet-netlink-route.c | 102 ++++++++++++++---------------
epan/dissectors/packet-netlink-sock_diag.c | 91 ++++++++++++-------------
epan/dissectors/packet-netlink.h | 1 -
7 files changed, 136 insertions(+), 177 deletions(-)
