Wireshark-commits: [Wireshark-commits] master 3b781db: rtp_player_dialog: Route audio for a stream
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 08 Jan 2020 11:50:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b781dbab5f29928415951db5e8f7d740a615a3d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3b781db by Jirka Novak (j.novak@xxxxxxxxxxxx):

    rtp_player_dialog: Route audio for a stream to left/right speaker in RTP player
    
    Column 'Play' added to player. Double click on a stream in the column changes
    audio routing for the stream.
    When soundcard supports only one channel, there are Mute/Play option. When
    soundcard supports two or more channels, there are Mute/L/L+R/R options.
    Muted channel is drawn with dotted line.
    
    Change-Id: If120c902195da46f98a1663c589f20c6a1da0ba7
    Reviewed-on: https://code.wireshark.org/review/35687
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ce6952d   packet-smb2: add support for SMB2_FILE_NORMALIZED_NAME_INFO
     add  3b781db   rtp_player_dialog: Route audio for a stream to left/right speaker in RTP player


Summary of changes:
 ui/qt/rtp_audio_stream.cpp  |  69 +++++++++++++++++----
 ui/qt/rtp_audio_stream.h    |   7 ++-
 ui/qt/rtp_player_dialog.cpp | 147 +++++++++++++++++++++++++++++++++++++++++---
 ui/qt/rtp_player_dialog.h   |  18 +++++-
 ui/qt/rtp_player_dialog.ui  |   5 ++
 5 files changed, 219 insertions(+), 27 deletions(-)