Wireshark · Wireshark-commits: [Wireshark-commits] master ad0aecb: addr_resolv: avoid unnecessary memory allocation for hash tables

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad0aecbf8bc3ce0de24f52ae711e184b2fb16c49
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ad0aecb by Peter Wu (peter@xxxxxxxxxxxxx):

    addr_resolv: avoid unnecessary memory allocation for hash tables
    
    The key for the manuf table is 24 bits of the ether addr while the key
    for services table needs is a 16 bit port. Store this value directly,
    saving some memory and improving startup time by a tiny bit.
    
    Likewise for ipxnet_hash_table and vlan_hash_table. These tables seem
    unused though, perhaps it should be removed.
    
    Change-Id: Ide9ffad8e2c9af24afa82adb2e009f32a5f43d38
    Reviewed-on: https://code.wireshark.org/review/30756
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e7220aa   addr_resolv: speed up reading manuf, services, etc.
     add  ad0aecb   addr_resolv: avoid unnecessary memory allocation for hash tables


Summary of changes:
 epan/addr_resolv.c                  | 65 ++++++++++++++-----------------------
 ui/qt/resolved_addresses_dialog.cpp | 10 +++---
 2 files changed, 30 insertions(+), 45 deletions(-)