Wireshark · Wireshark-commits: [Wireshark-commits] master ada5b88: TFTP: De-duplicate tftp_info structure creation.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ada5b886477df5a8ce90ced0fa59f776480b2b5d
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ada5b88 by Darius Davis (darius@xxxxxxxxxx):

    TFTP: De-duplicate tftp_info structure creation.
    
    Cleanup to unify the two distinct places where tftp_info was identically created
    and initialized.  While we're here, remove two unnecessary initializers of
    'conversation'.  Behavior should be unchanged.
    
    Testing Done: On macOS 10.12.6, built Wireshark, and examined a handful of TFTP
       packet captures in the GUI.
    
    Change-Id: I9702a3dbeea357ec903166144918a71abc742846
    Reviewed-on: https://code.wireshark.org/review/30758
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  ad0aecb   addr_resolv: avoid unnecessary memory allocation for hash tables
     add  ada5b88   TFTP: De-duplicate tftp_info structure creation.


Summary of changes:
 epan/dissectors/packet-tftp.c | 62 ++++++++++++++++++-------------------------
 1 file changed, 26 insertions(+), 36 deletions(-)