Wireshark · Wireshark-commits: [Wireshark-commits] master e7220aa: addr_resolv: speed up reading manuf, services, etc.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7220aad1b6935abb9025e23fa2fdb4936cdaeaf
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e7220aa by Peter Wu (peter@xxxxxxxxxxxxx):

    addr_resolv: speed up reading manuf, services, etc.
    
    An unoptimized, Debug+ASAN `tshark --version` takes about 1 second. 17%
    of the cycles are spent in addr_resolv_init and 7% within fgetline. Use
    fgets instead, now fgetline only costs ~0.5% (11% for addr_resolv_init).
    
    This limits the line length to 1K which should more than be sufficient
    for all involved files (longest lines: manuf 154, services 222).
    
    Change-Id: I8fe4dff317beaa2926c4106909b10898bcd35f21
    Reviewed-on: https://code.wireshark.org/review/30755
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  36d26b3   Update text2pcap documentation
     add  e7220aa   addr_resolv: speed up reading manuf, services, etc.


Summary of changes:
 epan/addr_resolv.c | 88 ++++++++++++++++--------------------------------------
 1 file changed, 25 insertions(+), 63 deletions(-)