Wireshark · Wireshark-commits: [Wireshark-commits] master cc412a6: packet-opensafety.c: Fix two bugs:

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc412a6cdf5321925ff0d35f0bcc28b42af69483
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cc412a6 by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-opensafety.c: Fix two bugs:
    
    - Actually register dissector on default UDP ports upon startup.
    - expert_...() shouldn't be called under 'if (tree)'
    
    Also: cleanup proto_reg_handoff...() and apply_prefs() code.
    
    Change-Id: I6390d9bf311c9a62fbc43647d9bb19f90156baec
    Reviewed-on: https://code.wireshark.org/review/4063
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  5ff7a26   Minor performance tweaks: - Only calculate tvb length once. - Use tvb_reported_length() instead of tvb_reported_length_remaining() as   this is a subtvb offset is always 0.
    adds  cc412a6   packet-opensafety.c: Fix two bugs:


Summary of changes:
 epan/dissectors/packet-opensafety.c |   86 ++++++++++++++++++-----------------
 1 file changed, 44 insertions(+), 42 deletions(-)