Wireshark-commits: [Wireshark-commits] master-1.12 7da6c7e: packet-opensafety.c: Fix two bugs:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Sep 2014 14:59:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7da6c7e459cea90b1481abcabf4b3268d3c4671e
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

7da6c7e by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-opensafety.c: Fix two bugs:
    
    - Actually register dissector on default UDP ports upon startup.
    - expert_...() shouldn't be called under 'if (tree)'
    
    Also: cleanup proto_reg_handoff...() and apply_prefs() code.
    
    Change-Id: I6390d9bf311c9a62fbc43647d9bb19f90156baec
    Reviewed-on: https://code.wireshark.org/review/4063
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    (cherry picked from commit cc412a6cdf5321925ff0d35f0bcc28b42af69483)
    Reviewed-on: https://code.wireshark.org/review/4064
    

Actions performed:

    from  a706f62   Fix some spelling and grammar in user-visible text strings.
    adds  7da6c7e   packet-opensafety.c: Fix two bugs:


Summary of changes:
 epan/dissectors/packet-opensafety.c |   86 ++++++++++++++++++-----------------
 1 file changed, 44 insertions(+), 42 deletions(-)