Wireshark-commits: [Wireshark-commits] master 5ff7a26: Minor performance tweaks: - Only calculate t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Sep 2014 13:16:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ff7a2639ca8a35e544119ae742ec208a47f9e74
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5ff7a26 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    Minor performance tweaks:
    - Only calculate tvb length once.
    - Use tvb_reported_length() instead of tvb_reported_length_remaining() as
      this is a subtvb offset is always 0.
    
    Change-Id: I03bd7a95061488d4576fa93f26e6b31d55f88738
    Reviewed-on: https://code.wireshark.org/review/4060
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c6c8dc2   Make expert info text less verbose for missing ICMP response - no point in including frame number
    adds  5ff7a26   Minor performance tweaks: - Only calculate tvb length once. - Use tvb_reported_length() instead of tvb_reported_length_remaining() as   this is a subtvb offset is always 0.


Summary of changes:
 epan/dissectors/packet-diameter.c |   29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)