Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5819] New: Not possible to use "@" character in coloring rules.

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5819

           Summary: Not possible to use "@" character in coloring rules.
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: plyschbjorn@xxxxxxxxxxx


Build Information:
wireshark 1.5.2 (SVN Rev 36552 from /trunk)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.20.1, with GLib 2.24.1, with libpcap 1.0.0, with
libz 1.2.3.3, without POSIX capabilities, without libpcre, without SMI, without
c-ares, without ADNS, without Lua, without Python, without GnuTLS, without
Gcrypt, without Kerberos, without GeoIP, without PortAudio, without AirPcap.

Running on Linux 2.6.32-30-generic, with libpcap version 1.0.0, with libz
1.2.3.3.

Built using gcc 4.4.3.
--
Using a display filter looking like this is no problem:
sip.Call-ID == "6190411.2724@10.80.54.151"

However, if I try to create a color rule with the exact same filter, I get the
following error:
"
  Filter names and strings must not use the '@' character. Filter unchanged.
"

It is ./gtk/color_edit_dlg.c preventing this with the following lines of code:

  if(strchr(filter_name,'@') || strchr(filter_text,'@')){
    simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK,
                  "Filter names and strings must not"
                  " use the '@' character. Filter unchanged.");
    g_free(filter_name);
    g_free(filter_text);
    return;
  }

I have removed these lines and recompiled Wireshark, and now it is possible to
successfully use 'sip.Call-ID == "6190411.2724@10.80.54.151"' as a color
filter.

However, those lines of code must have been there for a reason. Is that reason
still valid or can they be removed and be considered a bug fix?

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.