Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 5819] Not possible to use "@" character in coloring rules.

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5819

--- Comment #4 from Sake <sake@xxxxxxxxxx> 2011-04-12 08:16:03 PDT ---
(In reply to comment #2)
> Yes, the color filter worked as expected; all SIP sessions with the specific
> Call-ID got the correct color.
> 
> However, I only tested that one thing; I have not done anything else with
> Wireshark today. Maybe I should run it like this for a while, to see if I run
> in to any other issues!?
>
> Do you know of any specific functionality I can test, that "should" fail due to
> my changed code?

The test would be to close wireshark after entering the new coloring rule, then
open Wireshark again and see whether the filter and coloring is still correct.

Internally wireshark is capable of having this filter. It's in the writing and
reading of the colorfilters file that fields get separated by the @ character.
And it is then that things go wrong:

                /* retrieve filter expression */                i = 0;
                while (1) {
                        c = getc(f);
                        if (c == EOF || c == '@')
                                break;

(from color_filters.c)


So to be able to save and load the colorfilters file, there needs to be code
written to escape the @ in some way.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.