Wireshark-bugs: [Wireshark-bugs] [Bug 3894] File-Open Display Filter is overwritten by Save-As F
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3894
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #5289| |review_for_checkin?
Flag| |
--- Comment #2 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-10-12 11:54:51 PDT ---
Created an attachment (id=5289)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5289)
Set display filter strings back to NULL after use.
The attached patch appears to fix the reported problem with the display filter
used during File->Open, but I also found that it occurs during File->Merge, so
the patch attempts to fix that as well.
The patch also makes the dfilter_[open|merge]_str's static since they aren't
used outside of file_dlg_win32.c.
I'm not 100% sure this is the best/right way to fix this problem though, but it
appears to work.
One other "problem" I found while testing is that if you apply a filter during
File->Open such that not all packets from the file are displayed, then do a
File->Save As, all packets from the original file are saved, regardless of
whether they were displayed to begin with or not. Is that the intended
functionality? It seems counter-intuitive to me.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
