Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 3894] File-Open Display Filter is overwritten by Save-As Filename

[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3894

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5289|review_for_checkin?         |
               Flag|                            |
   Attachment #5289|0                           |1
        is obsolete|                            |
   Attachment #5291|                            |review_for_checkin?
               Flag|                            |

--- Comment #3 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-10-13 08:39:53 PDT ---
Created an attachment (id=5291)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5291)
Fix duplicate idx's.  Set display filter strings back to NULL after use.

This patch fixes a bug in wsutil/unicode-utils.c whereby the same idx variable
was being used in 2 different arrays, which I believe is the root cause of this
bug.

The patch also initializes each idx to 3 so the first position in the array
will end up being the one used after the increment and mod operation.  I also
increased the size of utfXbuf[] arrays from 3 to 4 because ... well because I
like powers of 2 :)

And while the changes to file_dlg_win32.c aren't absolutely necessary, I happen
to like the behavior better, so I left them in.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.