Ethereal-dev: Re: [Ethereal-dev] Getting rid of ui_util.h mess?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sat, 20 Aug 2005 16:08:47 +0200
Joerg Mayer wrote:


On Sat, Aug 20, 2005 at 01:15:31PM +0200, Ulf Lamping wrote:

The intend (I think) is to keep the UI dependant parts out of the / dir.


Why? There are 5 files in the top level dir that include ui_util.h. Either
they have to know about the gtk specific stuff or not. If they should not
include stuff from the gtk/ dir, maybe they should be moved into the gtk/
dir?
I think the intend was to probably support other GUI toolkits later, so all GTK independent but GUI related things keep in these files in /. 


If we really want to keep that concept, then yes, something like that.
And that file should be included in all the files in gtk/ that implement
one of the functions declared in that file to ensure consistent declarations.
Maybe gtk_utils.h would be a better name.
gtk_utils.h sounds like coming from the GTK libs, so probably not a well chosen name.
I try to prevent to name our own stuff with the g_ (for GLib) or gtk_ (for GTK) prefix as that's used by that libs. 

Regards, ULFL